2
0
mirror of https://opendev.org/x/pyghmi synced 2025-01-15 12:17:44 +00:00

257 Commits

Author SHA1 Message Date
Jarrod Johnson
7ba12de874 Gather Thinkserver CPU and Memory independently
If CPU inventory is unavalible, proceed to get memory inventory.
If memory inventory is unavailable, cleanly omit the data.

Change-Id: If9d5eec1aa5dcc7a2800e30636ff4cedee48a311
2015-06-11 14:33:12 -04:00
Jarrod Johnson
59d7945957 Handle Lenovo Thinkserver lacking OEM inventory
If a Thinkserver responds negatively to request for OEM
inventory data, gracefully drop out and return empty
information rather than passing it up the stack.

Change-Id: I16d176606bb95d56244dfea43f9d828ff046bbc1
2015-06-11 13:36:31 -04:00
Jarrod Johnson
d6f0a2797a Add record id to SEL data
Provide calling code with the identifier number for a particular event.

Change-Id: Icc274e5475b7a266c1ff36bdc796197e98256a8c
2015-06-10 13:46:12 -04:00
Jarrod Johnson
26942c7860 Provide extensibility to sensors by OEM
OEMs frequently employ special commands for data that logically
would be expected to manifest as a sensor.  Provide a facility
for OEMs to make up sensors and provide data in the form of a
'sensor' without requiring SDR.

Change-Id: I6bce99680ff64ffe2dbc0898d193a17dde066b9c
2015-06-09 11:11:02 -04:00
Jarrod Johnson
9e64b16291 Provide interface for decoding PET alerts
Enable a python application tasked with decoding PET
coming in via SNMP to decode it in the same manner
an event log entry is decoded.

Change-Id: If8272989ba5d9062183e5decab959729dda85d62
0.8.0
2015-06-08 09:55:40 -04:00
Jarrod Johnson
249ea5dda2 Handle unknown entity ids
Vendors can do other entitiy ids.  Have a catch all
that provides the raw value in case there
is no better lookup for the number.

Change-Id: I66a226e1b38f6b31b95bfe58e044875decae09a8
2015-06-05 13:55:30 -04:00
Jenkins
aeece54e4c Merge "Tolerate alternative return code for FRU size" 2015-06-05 15:29:39 +00:00
Jarrod Johnson
6cfa823ea9 Tolerate alternative return code for FRU size
202 means 'Cannot return number of request bytes', which is pretty on the nose
for the scenario at hand.  Include that in the conditions to reduce the request size.
Thanks to Rafael Debarros for this.

Change-Id: I833faf2559a93e468748a72db29e6967bc800207
2015-06-05 11:00:25 -04:00
Jenkins
2ce2665933 Merge "Remove libvirt from requirements" 2015-06-03 19:09:15 +00:00
Jarrod Johnson
7f88daa8ca Remove libvirt from requirements
Only some use the virtual bmc function.  Remove it
from requirements to make packaging easier.

Change-Id: I464450f8b6a6bfc7fd6ff189f1a9b680d96d928f
2015-06-03 14:37:31 -04:00
Jarrod Johnson
f88c8e8839 Provide access to get/set community string
For SNMP alert processing, each channel can have an associated
community string.  Provide access to this configuration parameter.

Change-Id: Ib1cb98e436fc104d803ef7e594b92c46f8756171
2015-06-03 14:35:48 -04:00
Jarrod Johnson
728969a7bf Add serial field from SPD
Add serial number data from SPD to standard SPD decode

Change-Id: I380d6a36726daf0a9c23ab0bf8245f4b8c975658
2015-06-03 13:24:11 -04:00
Jarrod Johnson
25edd1ac31 Implement OEM Inventory components
Provide a framework for OEM to add inventory devices
without requiring FRU locator records.  This enables
vendors to provide additional data in a more flexible
scheme.

Change-Id: I9ef9685de9150940321aecbf2cc275cfbbe8ce6a
2015-06-03 10:09:35 -04:00
Jarrod Johnson
9efd878fd5 Report/Configure LAN alert destinations
Provide a facility to manipulate the LAN alert destinations.
Additionally update the LAN configuration functions to have
a function to intelligently find the correct LAN channel.
For now the 'check current channel' preference should always
activate, but the function should be able to cover a hypothetical
in-band scenario should session become so enabled.

Change-Id: I45ce81addb882110e04d0526997a96b6b2ab0c2e
2015-05-29 13:41:01 -04:00
Jarrod Johnson
8b94506ce9 Implement Thinkserver OEM SEL decode
The Thinkserver platform may have a number of OEM entries.
Provide a reasonable decode of those events.

Change-Id: Ie4be9848293c00e8b0d3490075101ed8be1cf72e
2015-05-20 15:16:54 -04:00
Jarrod Johnson
3db5df1b4a Fix behavior with some Lenovo Thinkservers
FRU data may return 0x81 on not-present devices and also
provide some rough event description in the case of an
unknown OEM SEL format.

Change-Id: Ia99c4981c06ed8e067a584896fde3880f08f8baa
2015-05-19 16:51:29 -04:00
Jarrod Johnson
e019fb4c88 Only conditionally delete fields from event
If some events (for example, OEM events) are encountered,
the deleted fields won't exist in the first place.  Avoid
KeyErrors by checking before deleting.

Change-Id: I91ca73f4288c7b877589e766c8ce1ea1166e0d37
2015-05-19 15:38:56 -04:00
Jarrod Johnson
329e9fc188 Fix python2.6 usage of unpack_from
unpack_from in python 2.6 can't handle a bytearray.  Make it a buffer
before trying to unpack_from

Change-Id: I0b1014eba7b1001e79edb2bee1e1dc5b59eda36c
2015-05-15 16:08:45 -04:00
Jarrod Johnson
369463eb9f For unspecified sensors use None as the component
Rather than use the string 'Unspecified', use the
None object to denote an event that has no associated
component.

Change-Id: I8b8431257a01434ec09aaa940fab5bbce2164ae6
2015-05-15 14:50:13 -04:00
Jarrod Johnson
612c3fb303 Update decode of HDD OEM events for Lenovo
The specification actually only has the lower 5 bits refer to the slot
number.  Mask out the upper three bits to be accurate.

Change-Id: I654f7a96ad1ae2fd18430ca73aa33b30ce80a8e2
2015-05-15 13:10:41 -04:00
Jarrod Johnson
077941dbfb Declare one sort of 'non-redundancy' ok
This class of non-redundant simply means the resource is inherently
non-redundant per its current configuration.  Other sorts of non-redundant
are available to indicate when this is a consequence of failure.

Change-Id: I0326d13159ccffd2ad790fc8d14fefec17cc2671
2015-05-15 11:04:57 -04:00
Jarrod Johnson
01980e40e9 Add OEM event fixup
Provide a facility for OEM plugins to modify events on the way
out of the event handling functions.

Change-Id: I24f31f7035dcba2c1f30810a6282c87ee987ddad
2015-05-14 16:34:31 -04:00
Jenkins
911762f0c5 Merge "Change event text based on assertion/deassertion" 2015-05-14 18:58:22 +00:00
Jarrod Johnson
6db3e65b0a Change event text based on assertion/deassertion
For the text description and severity, use the negated values
added previously to make it more clear what an event represents.

Change-Id: I9eb47363d5f190bd0fd5bec58bc49fa12a9a3ed0
2015-05-14 14:53:40 -04:00
Jarrod Johnson
c1f6cacd95 Tolerate missing UUID
Some Thinkservers may be missing the UUID field.  Tolerate
this scenario gracefully.

Change-Id: I43793b509030be9b7c161d8fee80cf67b831bbdd
2015-05-14 14:46:45 -04:00
Jarrod Johnson
006710f1e8 Rename 'entity' to 'component'
IPMI carries a connotation of what an 'entity' is.  While
sticking strictly to the nomenclature of 'sensor' that actually
maps would be misleading, entity is also confusing.  Renaming
the element to be 'component' to express what it tends to represent
without getting confused with the IPMI concept of 'entity'.

Change-Id: I592e1e6b9588bf381588c7d9d3e6531eb277d23c
2015-05-14 13:31:44 -04:00
Jarrod Johnson
ab8939910f Leave numbers intact
Some callers of the code would like to use an enumeration
rather than using the strings verbatim or as a key.
Accomodate this through adding fields to carry those
data for such callers.

Change-Id: I75442a12448cdee1e7c0cb99501d6f229cc0c2b2
2015-05-13 16:53:24 -04:00
Jenkins
00da052032 Merge "Flesh out and rework some sensor descriptions" 2015-05-13 17:24:42 +00:00
Jarrod Johnson
d3ccfa3731 Flesh out and rework some sensor descriptions
While implementing events, it suggests that the severity and deassertion
of events warrants a distinct set of enumeration.  Additionally,
the structure made it clear that many of the sensor offsets and their
sensor_type indicated strings were redundant with each other, and
language was changed to eliminate that redundancy.

Change-Id: I1c2f733c4ffb1e7ac2ad8b1004bd560487117b66
2015-05-12 14:48:51 -04:00
Jarrod Johnson
c28ff05b1e Break out of FRU read if zero data returned
If a BMC returns 0 data, then assume end of data has been
reached.  Not all implementations accurately advertise FRU
size, so this is a way to detect and break out.

Change-Id: I03d0393563f8527e16830098b649ae940ee7ee9e
2015-05-07 10:47:23 -04:00
Jarrod Johnson
8c8ce504c1 Fix time correction code
When the change to refactor the event and event_data happened,
the time correction code was not correctly modified.  Rectify
the mistake.

Change-Id: I8317539761456f1c5621745989fbd8ebfc973455
2015-05-06 16:45:30 -04:00
Jarrod Johnson
dd53abfb99 Decrease severity of 'Disabled' presence
This is generally used to indicate the benign configuration
choice of disabling some present device.  For example, a
server with a built in network device disabled in favor of
an add-in option.

Change-Id: I1cf9f4feccf7ec022cca7ce7909093b16807244c
2015-05-06 15:59:15 -04:00
Jarrod Johnson
349a4aa2eb Rename description field and split data out
It would be good for some consumers to have the broad event
description separated from the event specific data.  Facilitate
this with language that makes more clear the piece that refers
broadly to a class of things that can go wrong versus the
potentially very specific data associated with that event.

Change-Id: I983dc1cdf59ae8bc08db3ff3f55192e82f693dbe
2015-05-06 15:45:11 -04:00
Jarrod Johnson
0967ac6025 Implement event log retrieval from BMCs
BMCs retain historical event data in the SEL.
Implement code to read through the SEL.  It
also passes the processed data to the OEM
framework for further processing since
OEMs may define a number of events.
Note that it is not necessarily the OEM of
the system that defines the OEM decode of the
event.  A timestamped OEM event may contain a
different OEM id.  This permits things like
the system, the OS, agents, et all to use the
SEL to store various things.

Change-Id: Ibfb07146b1dfa0ce06df863e805b5a30f17d2f18
2015-05-06 10:44:33 -04:00
Jarrod Johnson
54b90439e7 Add system UUID to inventory
While not strictly in the FRU area, it is often desirable
to have the system UUID available.  The intent is for the
UUID to match what dmidecode would return.  If a manufacturer
does it right, that UUID will be unique.  For ThinkServers,
override with the UUID from the OEM FRU fields rather than
using the get system UUID result.

Change-Id: Ie9a1b7e8fee2cb40ab679cbf2df04db61fd4e42f
0.7.1
2015-04-29 10:54:39 -04:00
Jarrod Johnson
d022c58e61 Fix parsing of 6bit ascii
The 6 bit ascii decode was not correctly assembling
the third character in every chunk.  It was incorrectly
masking away the most significant bit before shifting.
Correct the mask to only mask the appropriate bits.

Change-Id: Ib55ce934d2834d53879e64cc44bcf12bef0eef1c
0.7.0
2015-04-28 14:15:05 -04:00
Jarrod Johnson
f223ed7849 Clean up strings from FRU
Often, a vendor will pad their data fields with spaces.
Compensate through use of strip.  Similarly, some devices
elect to use spaces rather than ascii zeroes on Lenovo
devices, recognize those as not present fields as well.

Change-Id: I3e1d1ffd5dae4d4febc727e7193fa6652050b267
2015-04-28 13:58:39 -04:00
Jarrod Johnson
33de9a451f Add function to fetch a specific items inventory
It may be desirable for calling code to specifically call
out a single component.  Add the 'get_inventory_of_component' to
make that possible.

Also refine the OEM processors such that they should pass through
'None' to make some upper level code more straightforward.

Change-Id: Ic662d6c330af24fb8ed7a9cf2f8bcfd6202c1337
2015-04-27 13:43:24 -04:00
Jarrod Johnson
35c3a326a8 Tolerate errors in 'extra' fields
Some FRU has malformed data in the extra fields.
Tolerate this by giving up when out of data to
feed the parser, and returning what was parsed
to that point.

Change-Id: I9404c579e9020dd1afe668138eefba8266f1437b
2015-04-27 10:44:35 -04:00
Jarrod Johnson
e5bfd786cb Create framework for OEM extensions
While the base IPMI specification is quite comprehensive,
there are various points where OEM enhancement is possible.
This can run the gamut from entirely distinct function
(e.g. remote graphics) to additional 'sensors' to providing
more interesting decode of 'extra' fields in FRU to decoding
otherwise indecipherable SEL events.

Change-Id: Iaf670f336f225d0ea00e1803eebb84104a78e8b3
2015-04-24 15:52:07 -04:00
Jarrod Johnson
c60b684d23 Implement FRU inventory
Implement parsing of FRU data.  This phase omits Multirecord
area.  Provide access to either just the names or names
and extended information.

Change-Id: I8b0adf649769a880bf40cbe973864e889f1a6959
2015-04-23 13:56:22 -04:00
Jarrod Johnson
77593758f7 Try setting optional byte in set user acess
Set the user session limit explicitly to lift
any restrictions an implementation may default
to.  Some systems consider this byte mandatory
though the specification says optional

(From Steve Weber)

Change-Id: I95f4743ded702a436be019c902487813f916bd27
0.6.27
2015-04-01 09:12:39 -04:00
Jenkins
81fd13f3b3 Merge "Reduce cost of packet transmit" 0.6.26 2015-02-18 20:47:03 +00:00
Jarrod Johnson
cdef6531ca Reduce cost of packet transmit
eventlet only cares about multiple readers.  Multiple threads doing send
do not bother it.  As such, just call the sendto directly rather
than going through the hoop of an io_apply and the associated
event creation and wait and general confusion of jumbling
up the IO worker thread.  This seems to buy about 10%
performance gain in the ~100 server scenario doing get_health.

Change-Id: Ia671f201a43f32589324b37aadf79f21548aef35
2015-02-18 15:32:06 -05:00
Jarrod Johnson
cc0559d9b9 Ignore packet overrun in RAKP2 and RAKP4
At least one BMC with one firmware sends junk data
at the end of their RAKP2 and RAKP4 messages.  Tolerate
by ignoring that data, since it is harmless to ignore

Change-Id: I9417f26649c1be527fd9de7b648121f49452031b
2015-02-18 14:10:41 -05:00
Jarrod Johnson
f0d3050a79 Streamline and simplify IO Polling
Get more performance improvements by moving more of the
serialized effort into the IO thread to avoid churn.  This
also simplifies the issue with select being called without
recvfrom, allowing removal of the ignoresockets mechanism.
Also rework wait to avoid having to build lists that no one
ever consumes and move work out of the eternal loop
that only should happen at startup.  This has shaved an
additional 25% off of wallclock time in a single-processor
context for a given workload.

Change-Id: If321a69fabfb3ee55599ecfe3d24fbacd33388b5
0.6.25
2015-02-18 10:15:09 -05:00
Jarrod Johnson
b779379511 Reduce severity of a non-redundant state
A particular non-redundant state value has been observed
to more commonly describe a system that simply isn't
redundant by nature.  Rely on more ominous states and
sensors to convey truly problematic conditions.

Change-Id: I601fb6d358df626d9b12050c1f4a201121a7b264
0.6.24
2015-02-17 14:05:47 -05:00
Jenkins
a0a922309e Merge "Add missing generic discrete codes" 2015-02-17 18:58:09 +00:00
Jarrod Johnson
77aad5f728 Add missing generic discrete codes
A large chunk of generic discrete codes had been
skipped.  Rectify the omission and classify the
events.  Some debate could be had around 'non-redundant',
but the intent seems to be a way for a nominally redundant
component to describe a suboptimal state.

Change-Id: I48bbef96b7b6c952bcc940f5bb950962d07507d9
2015-02-17 13:40:14 -05:00
Jarrod Johnson
b4f265b2d7 Fix exceptions on sdr read
The string formatting is corrected for some 'bmc' errors.
It has been suggested to restructure things to not complain,
but so far when investigated, the systems actually had
a defect in putting the wrong sensor number in.  As a
diagnostic aid, this seems to be useful.  If a legitimate
application of duplicate SDR record for sensor is pointed
out, then we can restructure.

Change-Id: I58c2ffc1108cbb157f1398b420ea3a24bc4f05e8
2015-02-17 13:13:20 -05:00