When handling multiple sessions hiting a timeout expiry,
there was a chance that during recursion a session would
get redundantly scheduled for retry/timeout. Address this
by clearing out the scheduled sessions prior to acting on
any of the sessions. Additionally, only start the timeout
clock after successfully placing the payload on the wire,
rather than including local delays against timeout expiry.
Change-Id: I2f58f0afcb13943654489630f7e8164913633a49
While 'timeout' is not something defined in the IPMI spec
(it would make no sense), assign it an impossible value
so that calling code will experience timeout condition
as if it were a 'normal' ipmi error.
Change-Id: I8165497704148b79bc7996229f6f889b011e6d56
If SOL data comes in while trying to issue a command, the
caller had the risk of being bothered with unrelated execption
due to a failure to handle ack while waiting to send raw command.
If an exception occurs, silently mark the console object as closed
and move on.
Change-Id: I894d4f6596cf0546e8fe76ced0e309175198651d
In some cases, an exception warrants a different handling
depending on the code of the error. Have the exception
carry the code up for calling code to make a decision.
Change-Id: Ie7e134d3a7d99eaa1ec3a82c6f39e82dc4422ca7
In some cases, it is useful for management software to
specifically read one or a few sensors specifically.
This new function allows management software a convenient
way to get sensors without requesting a full sweep.
Change-Id: Ibbb7ab0d76b7aea934be804c6ee79c34f6a6c568
Provide a function to enumerate available sensors
without actually reading them. This paves the way
for management software to selectively query sensors
of interest depending on circumstance.
Change-Id: If63be5bc83996da10ee1fbb330395648340090bf
Provide framework for a utility to listen and respond to
ipmi protocol messages. Also provide an example 'fakebmc'
to give a general idea of how to create a ipmi device
Change-Id: I240b233ff161bc3672795b3ac3bf609e4c8c98bb
The environment variable IPMIPASSWORD is fetched without checking to see
if its present, which throws an exception instead of printing a usage
message if its not set. This patch fixes that.
Change-Id: I2b15efc4ea4b617e08f096de4130004150d64133
Files in bin/ don't have a .py extension, and so don't get picked
up by flake8. Add them to the flake8 command to have them checked.
Also fix an existing error in bin/pyghmicons.
Change-Id: I4db9b8c4e13c7c7f652acaa12add125f0e0458cd
Enable command method to turn on identify with full access
to duration and indefinite control. Note that there is no method
to retrieve it, as the specification does not provide that capability.
Change-Id: I3478101ed4db15232842b508a42aeb9ec9285434
While pyghmi supported the setting of the parameter,
it did not support the retrieval for the data. Remedy
this senseless asymmetry.
Change-Id: Ib26412e012d08b39df7b6997a1f929d4277219f9
If a thread has kill() after incommand was set, but before it actually
completed, then no fixup action will occur. Correct this by shrugging
off incommand if it was set more than the maximum possible timeout
before so that things can try to recover. An attempt was made with a
Lock and 'with', but kill() did not see the lock actually release, so
resort to expiring criteria instead.
Change-Id: I67d47a1533bf2e46db4534d9c1465bea08de6f64
With the socket pooling, we no longer have to be as aggressive about
trying to get packets out of the socket buffer. However, in a very
busy system of several hundred nodes, this aggressive processing
tends to produce larger python stacks and can exceed the default
1,000 limit. We may have to resort to increasing the limit one day,
but for now this case can be avoided.
Change-Id: I83bdaa2d8ad464727a69e6ece064f51cd4318822
It is possible for activity under 'raw_command' to modify custom
keepalive registry. Tolerate the structure changing in the loop gracefully.
Change-Id: I99c99b52718dff518c303819e7a24085cc6fb97a
If close is called and the remote BMC session no longer works,
do not pass up worrisome trace to a caller, which is calling close()
to try to make sure things are clean and here there is just some part
that was already done.
Change-Id: Ib0c770b57eb0f204bcde6fc786e8f064f02ece1a
On June 10 2014 one condition was addressed that caused infinite
recursion. Then it was an invalid timer that could fire in the midst of
a command. The case where this could validly occur was overlooked.
Address this by deferring invocation of keepalives until after command
exits. If incommand indicated activity advances timeout in non
custom keepalive case, then the keepalive timer will actually be correctly advanced.
Change-Id: Iebe0241c1f928c4187f167f3ffa407f8c6f7fa84
If an _io_apply encounters an exception, the io worker entirely would fall apart. Encompass the key entry
points in try clauses to allow the thread to keep working and the dependent IPMI object to have their
waiter acknowledged. It's still considered a grave bug for this to ever occur, but at least
the application would carry on.
Change-Id: I61b0797025b25c6d9d3e86a5110603a6fc2d67fb
In the IPMI spec, compact sensors have the numeric format reserved
and mandate an implementation set it to '3'. This mandate seems
to have been ignored by some implementations. Force the value to be
3 for all compact sensor records and assume the reserved bits may never
be used in a compact sensor.
Change-Id: I88f5d7b533869809f213ab0c5379b276af50cd23
In IPMI2, there are two modes the BMC can regard the Role parameter.
It can either consider it a 'max privilege' or 'match privilege'.
It defaulted to 'match privilege' in order to enhance compatibility
with some earlier BMC implementations that misinterpreted the
specification in a way that allowed 'match privilege' to work but
'max privilege' to break without a specific workaround for that BMC.
That BMC family is pretty much out of service and if the same issue
arises later, we can put in auto-detect and workaround pretty cheaply.
With this in mind, change the mode to look account up by name only
since that is how 99% of ipmitool invocations are done and it
also is a more straightforward model.
Change-Id: Ibf82b70e1b85e4e05c93365a684e21c434b4d5b4
Since we cannot hope to linearize a linearizable value without
understanding the formula (OEM or future spec), treat all unrecognized
linearizations and non-linearizable and rely upon get sensor reading
factors to determine the value. Add the capability to actually get
the sensor reading factors and then pass the resultant data through
the same decode_formula that would have been use had the factors
been retrieved through the SDR record.
Change-Id: I4c3a6bbbd6c68f7a0d19c2a7a221eb5fb57c99de
The method get() returns a value for the given key. If key is not
available then returns default value None. I think that was the
intention of the initial code.
Change-Id: I974258822d54f7ac09bc4197eb4ec249784012e7
In practice, generic discrete sensors have not indicated good *or* bad
health They have most commonly been used to indicate something like a
particular option being available or user disabled. This does mean
that something trying to use an utterly generic discrete sensor will
not trigger a health issue, but hopefully those cases leverage more
informative events that do have clear 'health' connotations. There
remains the chance that a sensor will rely upon the vocabulary of
the text in SDR and that just cannot be avoided.
Change-Id: I777b2f1300301291ca5a3aa7a6b18de1de6f9d1a
There is some inconsistency in the way BMCs may balk at pursuing a privilege level beyond
the user requesting. Add code to cope with two scenarios:
-RAKP2 returning 0xd
-set session privilege level returning 0x80 or 0x81
Change-Id: I500e5bbdf88b569b1f1c3f8476033be080770871
If two contexts call raw_command concurrently, there was a scenario
where the first to transmit has its result overwritten by the next to
send and corrupts the results of the first command. One scenario
where this was encountered was when a get health call was being
serviced at the same moment SOL attempted to open a console, causing
one of the get sensor readings to complain that 'SOL was already
active'. Address it by storing away lastresponse in a more context
specific place before deasserting 'incommand' and remove instances
that deasserted it earlier.
Change-Id: I504da3f54562a4b65b8f4e9e20c19aed9d21a09f
pyghmi was using any activity to defer any keepalive. If
a caller has a custom keepalive, only keepalive activity
should advance the keepalive expiry. Modify code to defer
keepalive only if it is the generic keepalive.
Change-Id: I852ad7a5de65af60fb8e11580bd2ef32896b71f6
Custom keepalives are called regardless of whether a command is issued
or not. The rationale being that custom keepalives are checking for
something specific rather than just assuring session state. Notably,
SOL uses a custom keepalive to see if the payload is still active.
The resultant problem was that if keepalive expired just at the time
something was in the midst of a command, a session would infinitely
recurse into its own keepalive. The issue was that the keepalive
expiry incorrectly omitted _monotonic_time, causing expiry to
always be far in the past. It normally did not break because if
not incommand, send_payload was setting an appropriate value after
the incorrect setting.
Change-Id: Ie86e49890a6ac96ddf07206fb1b8558161c00a20
Some configurations disable dual stack sockets. For example
if net.ipv6.bindv6only is 1 in linux, pyghmi was failing.
Address by explicitly requesting the converse behavior
on the socket since we explicitly do want to not care
whether a particular socket is engaged in ipv4 or ipv6
activity.
Change-Id: I17a16f0ebe4752ca743f115af39a367670691507
If trying to establish a session and an error occurs, pyghmi
was not decrementing the usage count on the pool, leading for
more than expected filehandles being created over time. Fix
this by correctly decrementing the count in the case where
something is not yet broken, but is also not yet logged in.
Change-Id: I1b27f9b3b902a253d38293182305cc4dac26b765
When open session fails, console continued trying to use the session
even though it is a lost cause. Correct this by bailing out in time.
Change-Id: Icc09514201c948edf21cf7e9e36f0cfe0520a2c9
When broken for whatever reason, we do not want timeout handling
to continue trying to heal the session. Notably bad when login fails
and a _relog is triggered continually.
Change-Id: Id342a7fc1274fe95483f2e5392b04f86d23c2b1a
When fixing the performance by declining to select() on a socket
until a recvfrom() explictly occurs to clear the socket, a problem
was injected where a socket could be made ignored by particular
timing of incoming traffic on the socket. Correct this by having
the _poller function forcefully return True if any sockets
are ignored (which also implies they are ready since they
should be discarded on read).
Change-Id: I6be39d39e4d2ed3b05af9a4c954fb64c993ffb50
If a session is partially ready to go, but not fully, drop packets.
This can occur if just the right packets drop such that the remote
end gets going but the local end does not receive them.
Change-Id: I63ac506484a1792db673f6e90e13cc4b0132719c
If no keepalives are registered, return cleanly from an
attempt to unregister rather than raise an exception.
Change-Id: I0064714af4ba8f1b62f9061dc0dc481116c871fe
When simulating 80% packet loss, it was discovered that a console
being close() due to inability to complete session establishment
will not have keepaliveid registered yet.
Change-Id: I839645b13cbe30ae71e104c44e63896a4802befe
Session establishment would fail to restart on loss due to deciding to
append to pending payload. Fix by having the establishment phase
reset the payload situation. On logout, the false to retry caused
raw_command to wait forever. Fix by having raw_command not bother
waiting for such things.
Change-Id: I26d2116bf78440b3ccfc319094283c5d7a58cc5e
When select() would identify a a socket, it would
potentially call select() on the same socket
before a recvfrom() would happen. In python 2.7,
this caused the IO thread to block other threads
waiting on something the other threads needed to
do. Resolve by explicitly ignoring a socket
where recvfrom() will be pending until recvfrom()
is next called. This reduces one test case from
42,000-47,000 select() calls to just 86.
Change-Id: Ic8ebecfc61d048e537b5d76a6a3f0665fd340a3d
command would return a number rather than a string for set_bootdev.
Correct this by returning the string passed in on success rather
than the resulting number.
Change-Id: I8e76b1ac9d0222630abe6b160e6271b13ef4987d
