xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-09-25 09:14:05 +00:00
Code Issues Releases Wiki Activity

fix(xcat-core): xcatd_install_monitor_concurrency.t passes when the file it reads is missing

Browse Source 
xcatd_install_monitor_concurrency.t called plan skip_all when xCAT-server/sbin/xcatd was absent, so a checkout that lost
the file reported 0 tests and exit 0. A test that cannot fail measures nothing.

Die instead, which is what makentp_ntp_deps.t already does for setupntp.

With xCAT-server/sbin/xcatd moved aside the file now exits 2 and prints "xcatd not found at <path>";
before this change it exited 0 and printed "1..0 # SKIP xcatd not found at <path>". With the file
present the test passes either way.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
This commit is contained in:
Daniel Hilst
2026-09-15 21:11:23 -03:00
parent 9e99dc2580
commit 36a3aee1a6
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xCAT-test/unit/xcatd_install_monitor_concurrency.t
+1 -1
View File
@@ -25,7 +25,7 @@ use Test::More;
use Time::HiRes qw(sleep time);
my $XCATD = "$FindBin::Bin/../../xCAT-server/sbin/xcatd";
plan skip_all => "xcatd not found at $XCATD" unless -r $XCATD;
die "xcatd not found at $XCATD\n" unless -r $XCATD;
my $SLOW = 3; # seconds one node's request spends in its plugin
my $EVENTS = "/tmp/xcatd-installm-events.$$";