From 36a3aee1a6c3382811f014b3b2df8854f6fd787a Mon Sep 17 00:00:00 2001 From: Daniel Hilst <392820+dhilst@users.noreply.github.com> Date: Tue, 15 Sep 2026 21:11:23 -0300 Subject: [PATCH] fix(xcat-core): xcatd_install_monitor_concurrency.t passes when the file it reads is missing xcatd_install_monitor_concurrency.t called plan skip_all when xCAT-server/sbin/xcatd was absent, so a checkout that lost the file reported 0 tests and exit 0. A test that cannot fail measures nothing. Die instead, which is what makentp_ntp_deps.t already does for setupntp. With xCAT-server/sbin/xcatd moved aside the file now exits 2 and prints "xcatd not found at "; before this change it exited 0 and printed "1..0 # SKIP xcatd not found at ". With the file present the test passes either way. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com> --- xCAT-test/unit/xcatd_install_monitor_concurrency.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xCAT-test/unit/xcatd_install_monitor_concurrency.t b/xCAT-test/unit/xcatd_install_monitor_concurrency.t index 999c8f90c..0e6447046 100644 --- a/xCAT-test/unit/xcatd_install_monitor_concurrency.t +++ b/xCAT-test/unit/xcatd_install_monitor_concurrency.t @@ -25,7 +25,7 @@ use Test::More; use Time::HiRes qw(sleep time); my $XCATD = "$FindBin::Bin/../../xCAT-server/sbin/xcatd"; -plan skip_all => "xcatd not found at $XCATD" unless -r $XCATD; +die "xcatd not found at $XCATD\n" unless -r $XCATD; my $SLOW = 3; # seconds one node's request spends in its plugin my $EVENTS = "/tmp/xcatd-installm-events.$$";