Commit bb460dc introduced a minor bug, where the value of LOCKEDUSERS
was no longer considered while handling existing entries in the user
list. This fixes that by adding back the check.
This patch redesign the original getadapter plugins. Currently,
getadapter do not work as a common command but only a chain command
works during discovery.
For systems that don't provide "Product Name", try to use "Product
Part Number" instead. Supermicro does this, for instance:
# ipmitool fru print 0
Chassis Type : Other
Chassis Part Number : CSE-118GQETS-R2K03P
Chassis Serial : [...]
Board Mfg Date : Sun Dec 31 16:00:00 1995
Board Mfg : Supermicro
Board Serial : [...]
Board Part Number : X10DGQ
Product Manufacturer : Supermicro
Product Part Number : SYS-1028GQ-TR
Product Serial : [...]
In some cases, FRU pages are not available, or don't contain relevant
readable or relevant information. In those cases, we could still fall
back to DMI to get the MTM information, and log a warning that
MTMS-based discovery may not work as expected.
Don't use information from DMI to populate the MTM field, as there is no
guarantee it will match with what's in the FRU pages. Since
`bmcdiscover` uses FRU information, use it in `dosdiscovery` too so they
will match for MTMS discovery.
There's an issue in this code where we query ntpq for the offset too quickly after starting the ntp daemon. This causes the offset to always be 0 and we continue. We have seen situations where ntpd starts before the first check and becomes > 1000. Then it takes 15 minutes before the 2nd attempt and delays the hardware discovery process
When changing the port when indicating NCSI
package, the comparison was inadequate. Improve
things by at least checking the shared/dedicated portion.
Note that it is not comparing the package id, which means
things are imperfect, though they are better than before.
However, it's not too shabby because the NIC being active
is the important part, the NCSI package change happening
later is ok, since the net config is still being put on
the correct IMM Nic.
