xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-01-07 17:02:34 +00:00
Code Issues Releases Wiki Activity

Fix DB error caused by alarm

Browse Source 
'xCAT::MsgUtils->trace' will retrive data from xCAT site table,
at this time timeout event happens and alarm signal received,
current process will exit unexpectly.

partial-bug: pmr 87739,077,724
This commit is contained in:
chenglch
2016-12-15 17:12:19 +08:00
parent c7eb8b8025
commit 3d3f367f69
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
xCAT-server/sbin/xcatd
View File

@@ -1514,9 +1514,6 @@ until ($quit) {
$$progname = "xcatd SSL: Instance for " . ($peername ? $peername . "@" . $peerhost : $peerhost) if $peerhost;
service_connection($connection, $peername, $peerhost, $peerfqdn, $peerhostorg);
$debugmsg = "xcatd: close connection with " . ($peername ? $peername . "@" . $peerhost : $peerhost) . "\n";
xCAT::MsgUtils->trace(0, "D", "$debugmsg");
xexit(0);
}
if ($sslfudgefactor) { $sslfudgefactor -= 1; }
@@ -2636,7 +2633,6 @@ sub service_connection {
my $peerfqdn = shift;
my $peerhostorg = shift;
my $peerport = $sock->peerport;
my %tables = ();
# some paranoid measures could reduce a third party abusing stage3 image to attempting to get USER/PASS for BMCs:
# -Well, minimally, ignore requests if requesting node is not in spconfig mode (stage3)
@@ -2873,12 +2869,10 @@ sub service_connection {
cmdlog_submitlog();
# ----used for command log end---------
my $debugmsg = "xcatd: close connection with " . ($peername ? $peername . "@" . $peerhost : $peerhost) . "\n";
xCAT::MsgUtils->trace(0, "D", "$debugmsg");
$SIG{ALRM} = sub { xCAT::MsgUtils->message("S", "$$ failed shutting down"); die; };
alarm(10);
foreach (keys %tables) {
$tables{$_}->commit;
}
$sock->close(SSL_fast_shutdown => 1);
if ($timedout == 1) {
printf("Client timeout");