xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-09-24 00:34:02 +00:00
Code Issues Releases Wiki Activity

style(xcat-core): the boot-file test comments retell the bug report

Browse Source 
Three comments in debian_install_boot_files.t explain more than the code
hides. One narrates the media table the assertions already list. One
repeats the nodeset error message and the releases that produce it. One
describes what mkinstall used to refuse before the change.

A comment states why, once, where the reader cannot re-derive it. Each of
the three now carries only the fact the assertions do not show.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
This commit is contained in:
Daniel Hilst
2026-09-14 08:23:53 -03:00
parent 0c27708c0f
commit 28e59642ca
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xCAT-test/unit/debian_install_boot_files.t
+7 -10
View File
@@ -7,10 +7,9 @@ use File::Temp qw(tempdir);
use FindBin;
use Test::More;
# The installer kernel and initrd sit in a different place on every Ubuntu media layout:
# netboot trees name them after the Debian architecture, live images keep them under
# casper, and a hardware-enablement kernel ships beside the release one. Build each layout
# on disk and ask the resolver, rather than reading the table that describes them.
# The installer kernel and initrd sit in a different place on every Ubuntu media layout.
# Build each layout on disk and ask the resolver, rather than read the table that
# describes them.
use lib "$FindBin::Bin/../../perl-xCAT";
use lib "$FindBin::Bin/../../xCAT-server/lib/perl";
@@ -103,10 +102,9 @@ is(
'riscv64 does not accept the kernel name the other live images use',
);
# The Ubuntu ppc64el live-server ISO carries no netboot tree at all. 22.04 and 24.04 ship
# casper/hwe-vmlinux + casper/hwe-initrd beside casper/vmlinux + casper/initrd; 26.04 ships
# the release pair only. Without these entries nodeset stops the diskful install with
# "The network boot initrd.gz is not found in <pkgdir>/install/netboot".
# The Ubuntu ppc64el live-server ISO carries no netboot tree. 22.04 and 24.04 ship the
# hardware-enablement pair under casper beside the release pair; 26.04 ships the release
# pair only.
is(
resolved('ppc64le', 'ppc64el', media('casper/vmlinux', 'casper/initrd')),
'casper/vmlinux|casper/initrd',
@@ -127,8 +125,7 @@ is(
'a POWER netboot tree still wins over a live image on the same media',
);
# mkinstall refused POWER media that carried no install/netboot/initrd.gz, whatever
# install_boot_files could resolve. One routine answers the question now.
# mkinstall asks this routine, so it accepts every media install_boot_files resolves.
can_ok('xCAT_plugin::debian', 'install_media_is_bootable');
is(
xCAT_plugin::debian::install_media_is_bootable('ppc64le', 'ppc64el',