xCAT/xNBA
2
0
Fork 0
mirror of https://github.com/xcat2/xNBA.git synced 2024-11-22 09:31:51 +00:00
Code Issues Projects Releases Wiki Activity
xCAT Network Boot Agent
4,202 Commits 4 Branches 0 Tags 13 MiB
C 94.5%
Objective-C 2.1%
Assembly 1.3%
Perl 0.9%
Makefile 0.4%
Other 0.7%
bc93e8ab41
Go to file
Michael Brown bc93e8ab41 [util] Avoid compiler warning on gcc 4.6 
Commit 196751c ("[build] Enable warnings when building utilities")
revealed a previously hidden compiler warning in util/nrv2b.c
regarding an out-of-bounds array subscript in the code

    #if defined(SWD_BEST_OFF)
        if (s->best_pos[2] == 0)
            s->best_pos[2] = key + 1;
    #endif

where best_pos[] is defined by

    #define SWD_BEST_OFF 1

    #if defined(SWD_BEST_OFF)
        unsigned int best_off[ SWD_BEST_OFF ];
        unsigned int best_pos[ SWD_BEST_OFF ];
    #endif

With SWD_BEST_OFF set to 1, it can be proven that all code paths
referring to s->best_off[] and s->best_pos[] will never be executed,
with the exception of the two lines above.  Since these two lines
alone can have no effect on execution, we can safely undefine
SWD_BEST_OFF.

Verified by comparing md5sums of bin/undionly.kpxe before and after
the change.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
2012-07-03 18:58:43 +01:00
contrib [contrib] Update bochsrc.txt to latest version of bochs 2012-06-06 20:37:53 +01:00
src [util] Avoid compiler warning on gcc 4.6 2012-07-03 18:58:43 +01:00
COPYING Initial revision 2005-05-17 16:44:57 +00:00
COPYRIGHTS [build] Rename gPXE to iPXE 2010-04-19 23:43:39 +01:00
README [doc] Re-add README file 2010-05-28 00:03:47 +01:00

README 

iPXE README File

Quick start guide:

   cd src
   make

For any more detailed instructions, see http://ipxe.org