This enables manipluating the feature in XCCs to
allow network connections to forward over USB port.
Change-Id: I577d6952e0dab4b9a9df8b6118fc75ed0173d366
Redfish now allows a system to opt to place virtual media
on system rather than manager. The rational being that
remote media has to be mapped to specific hosts, and the
manager relationship to that media can be implicit.
Try the system first (more specific) then fallback to traditional
manager location for virtualmedia.
Change-Id: I5d63b5e57572c6a753a2d86adb223335a15a71ea
Some resources are leaked on deletion
of a webclient without explicit close, improve
by destructor.
Change-Id: I91d313125bf79f83c3cd07e12e573b2bdd5a95ef
Various issues have been associated with trying to
reinitiate a session during a 'timeout' scenario, attempt
to clean up the various scenarios where it wasn't originally
designed to survive across a relogin.
Change-Id: Ifd9c8e98070217a1b0f4a35c8e0851a063b77800
If not logged in, continue to skip trying to reach BMC, but
do fire off internal cleanup.
This is technically an oversight, made worse by the recent changes
to 'unlog' as part of retry.
Change-Id: I0825c1f77decb81694f897b904a19a2f59587055
Some BMCs implement entry logs that are
not actionable. Trim those out to avoid empty data
for a user to scratch their head at.
Change-Id: I05ea62cdd3a56dfdeea4080774ec5a67a651824f
Previously, logon retries were not part of the normal
tries and treated separately. Now that
the normal retry logic is in place, a change
is needed to avoid the wait times amplifying.
Change-Id: Ia2e5b4f0790ce4574f17cf7ceb15ebd7a36f8afa
The health assesment can be much cheaper if the XCC health
assessment is trusted.
The issue would be that if the XCC web shows healthy, but the error LED
is lit, this condition would no longer be seen.
However, the error LED shouldn't be lit unless the XCC detects a fault.
So if such a condition of LED lit without explanation should arise in
the future, it would be better treated as an XCC firmware issue.
Change-Id: I55a4451eda4aba43fcf3d3e8e2307c3ce30b8fcd
The sequence number is never initialized unless the login already
happened, so we need to check for its existence when retrying failed
login.
Change-Id: Ia2319d4c0255d6ae8616cf0c736aaa30d65e6129
Sometimes a BMC just up and drops an IPMI session without warning.
The only way to recover is to login, so incorporate a login into the
retry logic.
Now a couple of retries are done the 'cheap' way (retransmit) followed
by a full login attempt.
This does mean that SOL sessions are less likely to survive a shared
nic outage during PXE boot or similar,
however we just have to take that hit.
Change-Id: Ica11d29519b1c69cbd151bce9100f8a7517544ca
Web session being expired should be mitigated by
forcing to start over if the session is more than
30 seconds old.
Change-Id: Iaa2abff9ab401a4e5285ea994028bf5f784ecc40
Python2 bytes type cannot be compared to number.
Coerce into a bytearray to have python2 treat
them as numbers.
Change-Id: I8522b1eb74f4b7aebfa6a0fa68107a0df947c7f6
Reseat returns success even when it
is not performed. Check for
shared io blocking prior to actually
attempting. This allows us to catch an error the firmware should have.
Change-Id: I683382236c0dc0683eba69d36e726056782aab10
Bump the cache version and just move away
from pickle. Upon closer thought, the
data being retained doesn't warrant a generic
format.
Change-Id: I3ba2b17eb2202cf64c8c0cdbf91addaf1325b5f0
While a cache is expected to be protected, mitigate
dangers by blocking code from being stored in pickle.
Change-Id: If3b942dd028da8580ec3f74e94081b30446ab8d9
Technically, the BMC is in error returning non-utf8 encoded content,
however, of *course* some BMCs fail to do so. Fallback to iso-8859-1
which will probably have bad data in a value somewhere, but it won't
break the entire parsing.
Change-Id: Id7c3c507a0eeb4c31ca52cfadf6ac77deefa3869
The capacity str may be GB or GiB or TB or TiB now.
Unfortunately, there's no normalized numeric in the api right now.
Change-Id: Iccfb6e837a0f2d5ac516c3e908c663bbddda2ed3
iDRAC does not support standard
redfish boot devices, provide oem override
in such case to use the OEM interface.
Change-Id: I53d7bb1d82035e621802c20f46000760cc8631a8
Certain redfish implementation only allow manipulation
of remote media through Actions. Detect when relevant
Actions are indicated and use them if offered.
Change-Id: I4eac9e5f4edb111f45551280fd98cdbc9c10c178
Previously, looking up an unknown OEM resulted in an exception being
logged:
exception while get_oem_handler, oemid:{'device_id': 32, 'device_revision': 1, 'manufacturer_id': 10876, 'product_id': 2414, 'firmware_version': '1.73'}
Traceback (most recent call last):
File "/omd/sites/plutex/local/lib/python3/pyghmi/ipmi/oem/lookup.py", line 43, in get_oem_handler
return (oemmap[oemid['manufacturer_id']].OEMHandler(oemid,
KeyError: 10876
So while I was at it, I also reduced duplicate code.
Signed-off-by: Jan-Philipp Litza <jpl@plutex.de>
Change-Id: Ib2483aeb3f92bcafbaa877eb1c0318a385f97474
Unrelated issue can derail an update process. Make pause
unlikely to throw unexpected issues, but print it out
just in case.
Further, give a hint when one specific scenario comes up that was
seen and hard to debug.
Change-Id: I635d3fc8df10b9bee9fc261d88beb7002b689a7e
While receiving the SDR, when the size is uneven, its division by 2
causes it to become a float instead of an integer, leading to a
TypeError later on:
Traceback (most recent call last):
File "gipmi/sdr.py", line 634, in __init__
self.read_info()
File "gipmi/sdr.py", line 665, in read_info
self.get_sdr()
File "gipmi/sdr.py", line 740, in get_sdr
sdrrec = self.ipmicmd.raw_command(netfn=0x0a, command=0x23,
File "gipmi/command.py", line 500, in raw_command
rsp = self.ipmi_session.raw_command(netfn=netfn, command=command,
File "gipmi/private/session.py", line 779, in raw_command
self._send_ipmi_net_payload(netfn, command, data,
File "gipmi/private/session.py", line 819, in _send_ipmi_net_payload
data = bytearray(data)
TypeError: 'float' object cannot be interpreted as an integer
Change-Id: I3e123487b27ef385823b1a20652195c7588f5d6c
