2
0
mirror of https://github.com/xcat2/confluent.git synced 2024-11-25 11:01:09 +00:00

Change ipmi console closure to only close SOL

Previously, was pulling the cord on a perfectly servicable IPMI
session object.  Change to just deactivating the SOL portion
of an IPMI connection if the console closes.
This commit is contained in:
Jarrod Johnson 2014-05-05 18:40:28 -04:00
parent 4db53fd00e
commit 811ee5eeda
2 changed files with 4 additions and 5 deletions

7
TODO
View File

@ -28,9 +28,8 @@ KeyError: ''
-have pyghmi and friends do multiprocessing pools
-investigate console behavior when target off (causing disconnects/reconnects
on input)
-with logging set to interactive or none, repeatedly connect to an ipmi
console that is actively outputting data. It seems that some race condition
causes creation of an ipmi console to result in a hung up console
-test to make sure that 'Session Disconnected' is working
-confetty to do right thing with respect to status updates when run right on a
console. It currently clutters up the screen with data that would land in
a titlebar
a titlebar
-audit log did not show confetty activity for starting console

View File

@ -150,7 +150,7 @@ class IpmiConsole(conapi.Console):
if self.solconnection is not None:
# break the circular reference here
self.solconnection.out_handler = _donothing
self.solconnection.ipmi_session.logout()
self.solconnection.close()
self.solconnection = None
self.broken = True
self.error = "closed"