From 811ee5eedacd3cd999aa6c449ea4de9fdf7615c4 Mon Sep 17 00:00:00 2001 From: Jarrod Johnson Date: Mon, 5 May 2014 18:40:28 -0400 Subject: [PATCH] Change ipmi console closure to only close SOL Previously, was pulling the cord on a perfectly servicable IPMI session object. Change to just deactivating the SOL portion of an IPMI connection if the console closes. --- TODO | 7 +++---- plugins/hardwaremanagement/ipmi.py | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/TODO b/TODO index 5571bf2f..22042929 100644 --- a/TODO +++ b/TODO @@ -28,9 +28,8 @@ KeyError: '' -have pyghmi and friends do multiprocessing pools -investigate console behavior when target off (causing disconnects/reconnects on input) --with logging set to interactive or none, repeatedly connect to an ipmi - console that is actively outputting data. It seems that some race condition - causes creation of an ipmi console to result in a hung up console +-test to make sure that 'Session Disconnected' is working -confetty to do right thing with respect to status updates when run right on a console. It currently clutters up the screen with data that would land in - a titlebar \ No newline at end of file + a titlebar +-audit log did not show confetty activity for starting console \ No newline at end of file diff --git a/plugins/hardwaremanagement/ipmi.py b/plugins/hardwaremanagement/ipmi.py index 0d4d7cf6..f04d3ea3 100644 --- a/plugins/hardwaremanagement/ipmi.py +++ b/plugins/hardwaremanagement/ipmi.py @@ -150,7 +150,7 @@ class IpmiConsole(conapi.Console): if self.solconnection is not None: # break the circular reference here self.solconnection.out_handler = _donothing - self.solconnection.ipmi_session.logout() + self.solconnection.close() self.solconnection = None self.broken = True self.error = "closed"