mirror of
https://github.com/xcat2/confluent.git
synced 2025-02-25 14:50:24 +00:00
Fix problem where reordering groups did not affect inheritence
There was an optimization to skip examination of groups if it was determined that the group membership had not changed. However, this erroneously masked the examination in the case of reordered groups. Skip the optimization to cover that case at the expense of at least some needless churn. This only happens when something goes to change group membership in some way, so this shouldn't be too expensive.
This commit is contained in:
parent
811ca61747
commit
79fc5faaf6
1
TODO
1
TODO
@ -1,4 +1,3 @@
|
||||
-Reordering a group does not reorder inheritance preferences
|
||||
-expressionkeys never gets smaller - perf impact
|
||||
-need event notification for config change- e.g. set attribute triggers consol
|
||||
session object check to see if credentials changed
|
||||
|
@ -541,8 +541,6 @@ class ConfigManager(object):
|
||||
self._cfgstore['groups'][group]['nodes'] = set([node])
|
||||
elif node not in self._cfgstore['groups'][group]['nodes']:
|
||||
self._cfgstore['groups'][group]['nodes'].add(node)
|
||||
else:
|
||||
continue #the group membership already existed, to next group
|
||||
# node was not already in given group, perform inheritence fixup
|
||||
self._node_added_to_group(node, group)
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user