From 79fc5faaf68f36f474a86fd6fa90708c3b16a940 Mon Sep 17 00:00:00 2001 From: Jarrod Johnson Date: Mon, 3 Mar 2014 15:35:08 -0500 Subject: [PATCH] Fix problem where reordering groups did not affect inheritence There was an optimization to skip examination of groups if it was determined that the group membership had not changed. However, this erroneously masked the examination in the case of reordered groups. Skip the optimization to cover that case at the expense of at least some needless churn. This only happens when something goes to change group membership in some way, so this shouldn't be too expensive. --- TODO | 1 - confluent/config/configmanager.py | 2 -- 2 files changed, 3 deletions(-) diff --git a/TODO b/TODO index 6ea5a5cc..0604ffb7 100644 --- a/TODO +++ b/TODO @@ -1,4 +1,3 @@ --Reordering a group does not reorder inheritance preferences -expressionkeys never gets smaller - perf impact -need event notification for config change- e.g. set attribute triggers consol session object check to see if credentials changed diff --git a/confluent/config/configmanager.py b/confluent/config/configmanager.py index acf80b77..9aef0c28 100644 --- a/confluent/config/configmanager.py +++ b/confluent/config/configmanager.py @@ -541,8 +541,6 @@ class ConfigManager(object): self._cfgstore['groups'][group]['nodes'] = set([node]) elif node not in self._cfgstore['groups'][group]['nodes']: self._cfgstore['groups'][group]['nodes'].add(node) - else: - continue #the group membership already existed, to next group # node was not already in given group, perform inheritence fixup self._node_added_to_group(node, group)