android/android_kernel_cmhtcleo
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

genirq: pm: Fix the enable ordering in resume

Browse Source 
In suspend interrupts are disabled from 0 to NR_IRQ, in resume interrupts
should be enabled in reverse order.

Enabling parent or summary interrupts before enabling child interrupts
causes the handler of the child interrupt to run even before it is
enabled. Usually the genirq handler does the correct thing of masking
the interrupt and additionally marking the interrupt IRQ_PENDING if its
an edge triggered interrupt. However the nested handler
(handle_nested_irq()) simply ignores the interrupt causing a loss of it.

Not calling the action of an interrupt, especially if it marked wakeup,
causes the system to incorrectly go back to suspend immediately.

Change-Id: Ica30c10a975a4a7b41b97b4f21250dac80335b2b
Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
This commit is contained in:
Abhijeet Dharmapurikar 2010-12-19 16:23:48 -08:00 committed by tytung
parent 520bef6caf
commit 43b7c2a243
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/irq/pm.c
View File

@ -51,7 +51,7 @@ void resume_device_irqs(void)
struct irq_desc *desc;
int irq;
for_each_irq_desc(irq, desc) {
for_each_irq_desc_reverse(irq, desc) {
unsigned long flags;
if (!(desc->status & IRQ_SUSPENDED))