android/android_hardware_qcom_display
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

libgralloc: Fix possible leak of fd

Browse Source 
Fix possible leak of fd in ion allocation.
If mmap fails close the fd before returning.

Change-Id: Id414792c14a75259f6075b0d76bc470c31fb5853
CRs-fixed: 387633
This commit is contained in:
Prabhanjan Kandula 2012-08-30 11:30:23 +05:30 committed by Andrew Sutherland
parent 36445e454b
commit e09a5d04db
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libgralloc/ionalloc.cpp
View File

@ -126,6 +126,8 @@ int IonAlloc::alloc_buffer(alloc_data& data)
ALOGE("%s: Failed to map the allocated memory: %s",
__FUNCTION__, strerror(errno));
ioctl(mIonFd, ION_IOC_FREE, &handle_data);
if(ionSyncFd >= 0)
close(ionSyncFd);
ionSyncFd = FD_INIT;
return err;
}