android/android_hardware_qcom_display
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

libcamera: avoid a race condition on starting and stopping a recording

Browse Source 
precondition: preview is running
-- call startRecording()
-- a preview frame arrives, causing the record callback to be called, and then
   blocks on mRecordWait.wait()
-- call stopRecording(), which sets mReleasedRecordingFrame and signals
   mRecordWait;
-- call startRecording(), which clears mReleasedRecordingFrame;
-- receivePreviewFrame() wakes up, checks mReleasedRecordingFrame, and
   blocks again on mRecordWait.wait(), without having notified the client.

Signed-off-by: Iliyan Malchev <malchev@google.com>
This commit is contained in:
Iliyan Malchev 2009-06-10 14:49:11 -07:00
parent ed604c67ee
commit 32b7f2804e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libcamera2/QualcommCameraHardware.cpp
View File

@ -1547,7 +1547,7 @@ void QualcommCameraHardware::receivePreviewFrame(struct msm_frame *frame)
if(rcb != NULL) {
Mutex::Autolock rLock(&mRecordFrameLock);
rcb(mPreviewHeap->mBuffers[mPreviewFrameOffset], rdata);
while(mReleasedRecordingFrame != true) {
if (mReleasedRecordingFrame != true) {
LOGV("block for release frame request/command");
mRecordWait.wait(mRecordFrameLock);
}