Daniel Hilst
edfe6a8840
build-ubunturepo guarded builds with a single host-global, fail-fast lock at /var/lock/xcatbld.lock (`flock -n`). Two builds on one host -- e.g. the devel and stable Ubuntu CD lanes on xcat-master-ub -- therefore collided on that one lock and the loser exited 1 with "Can't get lock ...", failing the whole pipeline, even though each lane builds from its own checkout into its own DEST and they share nothing. build-ubunturepo builds its packages in-place in its own source checkout (it rewrites debian/changelog and debian/control, drops *.orig.tar.gz at the checkout root and runs dpkg-buildpackage inside the package dirs), so the resource two concurrent builds actually contend for is the checkout, not the host. Key the lock on the checkout path ($curdir): builds of the SAME checkout still fail-fast (they would corrupt each other in-place), while builds of DISTINCT checkouts get distinct locks and run in parallel. The lock file stays on the local /var/lock (reliable flock, unlike the NFS/virtiofs checkout) and the source tree is left byte-pristine. Add xCAT-test/unit/build_ubunturepo_lock.t, which extracts the lock block from the script verbatim and asserts: the lock path is /var/lock/xcatbld-<hash-of-checkout>.lock and deterministic per checkout; a second build of the same checkout fails fast; two distinct checkouts acquire their locks concurrently. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test/unit
Unit tests. These run against the source tree only -- no xCAT installation, no running daemons, no management node.
They are executed on every pull request by the xcat_test GitHub Actions workflow,
which calls run_unit_tests() in github_action_xcat_test.pl:
prove -r xCAT-test/unit
You can run exactly the same thing from a clean checkout:
cd <xcat-core checkout>
prove -r xCAT-test/unit
What belongs here
A test belongs in unit/ when everything it needs is in the checkout: plugin and
library sources, kickstart/preseed/subiquity templates, postscripts, packaging
metadata. Such a test asserts on rendered output or module logic and reaches the
repository root through FindBin:
use FindBin;
use lib "$FindBin::Bin/../../perl-xCAT";
use lib "$FindBin::Bin/../../xCAT-server/lib/perl";
Because of those FindBin paths the tests only work from a source tree. The copy
installed under /opt/xcat/share/xcat/tools/autotest/unit is not a substitute --
../.. resolves to /opt/xcat/share/xcat/tools there and the tests die or silently
skip. The CI takes a copy of the checkout before the build for this reason; see
preserve_source_tree().
What does not belong here
Anything that needs an installed xCAT, a populated /install, a real service binary
or a live daemon. Those go in ../integration and run on
a management node through xcattest. Both suites run on every pull request -- the
workflow installs xCAT on the runner and then runs the ci_test cases against it --
so putting a test in integration/ does not cost it CI coverage. What differs is what
each suite is allowed to depend on, and that unit tests also run standalone from a
bare checkout with no xCAT at all.
The distinction matters because a test that needs an absent environment does not fail
-- it calls plan skip_all and reports as skipped. A handful of those in a suite of
several hundred assertions is easy to stop reading. Keeping the two kinds in separate
directories means a skip in unit/ is a real signal rather than routine noise.
Guarding on a source file, on the other hand, is fine and common here:
plan skip_all => "compute.subiquity.tmpl not found" unless -f $tmpl_path;
That guard never fires when the tree is intact.