mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-10-02 08:51:44 +00:00
Daniel Hilst
e832d26b2c
wget asks for the root image as //install/..., so the leading slash repeats. The path filter matched a single leading slash and did not count those requests. A service node that served only the root image would therefore read as having served no boot payload. The filter now accepts a repeated leading slash. The bats cases come from fix/service-node-ub, where a real Ubuntu service node logged one //install request beside 272 /install and 8 /tftpboot ones. Both new cases fail with the single-slash filter. This brings the file level with fix/service-node-ub, so the two branches no longer carry different versions of the same check. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
See unit/README.md and bats/README.md for the detailed rules for
each unit-test suite.