mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-04 20:17:55 +00:00
da282043be
buildrpms_source_only.t's CLI half failed in CI: the runner has no Parallel::ForkManager, so buildrpms.pl aborted at compile time and never reached the option check the test is about. The module is needed only by the test suite -- buildrpms.pl is not a runtime dependency of any package -- so it goes in the workflow apt list. The same half also escaped its scratch tree. Before buildrpms.pl looks at @ARGV it rewrites the tracked Gitinfo in its working directory and creates $HOME/rpmbuild, so running it from the checkout left the tree dirty and reached into the developer's home to exercise argument parsing. It now runs from a staged copy with HOME pointed at the sandbox. Exit 2 is pinned rather than "non-zero", though perl also exits 2 on a compile abort -- which is exactly how this assertion stayed green in CI while the program could not load. The message assertion is what separates the two, and the comment now says so. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>