mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-10-02 08:51:44 +00:00
Daniel Hilst
bcb4a77f1a
local_logs added XCAT_HTTPD_ACCESS_LOG to the list of candidate logs and then read the system paths as well. On a build host that runs apache, the check counted the host's own /var/log/apache2/access.log beside the file the test pointed at, so a test could not control what it measured. The empty-log case read 64 lines it did not write. An explicit XCAT_HTTPD_ACCESS_LOG now replaces the search instead of extending it. Production behaviour is unchanged: nothing sets that variable there. Without this change the bats case for an empty management-node log fails on a host that serves apache, and passes on one that does not. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
See unit/README.md and bats/README.md for the detailed rules for
each unit-test suite.