mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-25 09:14:05 +00:00
Daniel Hilst
9c2e733b99
site.cleanupdiskfullxcatpost names the node type it applies to, and site.5.rst says "on the diskfull nodes". xcatdsklspost serves every type: updatenode calls it for a diskless or statelite node as well, and the site value is one row that reaches all of them. With cleanupdiskfullxcatpost=yes and cleanupxcatpost=no, append_xcatpost_cleanup still appended the delete for those nodes. The diskful branch now reads NODESETSTATE from the generated mypostscript and appends nothing for netboot or statelite. That is the signal remoteshell, hardeths, configeth, otherpkgs and servicenode already use for this question, and mypostscript.tmpl exports it. cleanupxcatpost is unchanged. It names no node type and keeps applying to every one, which xcatdsklspost_xcatpost_cleanup.bats now asserts so a guard added to the wrong branch shows up. Four cases cover it: a netboot node and a statelite node keep their postscripts, a diskful node is still cleaned, and cleanupxcatpost still empties a netboot node. The first two fail against the parent commit. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
See unit/README.md and bats/README.md for the detailed rules for
each unit-test suite.