Daniel Hilst
980b7de169
Appendix A rows 15 to 18, the remaining spec decisions where the two backends answered the same client differently. Row 15, a loader that is not on disk is not named. The ISC architecture chain named every loader unconditionally, so a client whose loader was never built spent a full TFTP timeout it could not diagnose; the Kea side had always left the class out. The chain is now built from a list of gated branches rather than a literal block, because dropping a branch from a literal if/else if chain can leave a leading "} else if", which dhcpd rejects outright. Row 16, a *NOIP* interface draws no reply. Kea discards a packet assigned to the class named DROP, and only one such class may exist, so every dropped MAC in the cluster shares it and the user-context records which node each belongs to. Syncing one node merges into that list and removing one node prunes only its own entries, so makedhcp for a single node cannot bring another node's interface back. Row 17, a node that boots from disk, and row 18, a node deferring to proxydhcp, are decided per node. Kea host reservations outrank every client class, so the reservation has to fall silent -- an empty boot-file-name -- and let the class carry the answer. Rows 19 and 20 landed earlier and dictated the same shape: the reservation names nothing and two mutually exclusive classes, one for the vendor and one for "not the vendor", decide between them, because Kea evaluates every class independently and has no else.
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| DHCP wire tests | xCAT-test/dhcptest/ |
python3 -m unittest discover -s tests, then dhcptest run -i <nic> <conf> |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
dhcptest is the odd one out: its Python unit tests and dhcptest validate
run offline like the others, but its point is the third column -- driving real
DHCP transactions on a provisioning NIC and asserting on what came back. It
talks to the server only over the wire, so it is agnostic to which DHCP
implementation is answering and to xCAT itself.
See unit/README.md, bats/README.md and dhcptest/README.md for the
detailed rules for each suite.