mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-10-02 08:51:44 +00:00
Daniel Hilst
6382bf81e2
On the Ubuntu 24.04 hierarchy cell the check reported the right counts and then failed: "xcat22-sn served xcat22-cn 277 boot-payload request(s)", "xcat22-mn-dhilst served xcat22-cn 0", and then "no httpd access log with new entries could be read on xcat22-mn-dhilst". The guard required the management node log to gain lines after the baseline. It does not: the management node provisions the service node in SN_setup_case, before the baseline the hierarchy case takes, and it is then idle. Its silence is the result the check exists to find. The guard now asks that the log hold at least one line, which is what makes a count of 0 mean something, and no longer asks for activity in the measured window. The path filter also missed a doubled leading slash. The compute node fetches the root image with wget as //install/netboot/<os>/<arch>/compute/rootimg.cpio.gz, which the service node logged and the filter did not count. check_provisioning_source.bats covers both. The four cases added in the commit before this one fail without this change. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
See unit/README.md and bats/README.md for the detailed rules for
each unit-test suite.