mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-25 09:14:05 +00:00
Daniel Hilst
5f5ebcde7e
The install monitor answers a node's requests in the order they arrived. Two ways to lose that order had no test. The first is a queued client that gives up. The parent holds the later connections for a busy node unread, so a client that closes its socket must not let the request behind it overtake the request that is running. The new case runs one request, queues two more, drops the middle client, and asserts the last request starts after the running one ends. It fails when the per-node queue is removed. The second is a fork that fails. The monitor then answers the node itself, in line. The new case makes one fork fail and asserts the request is answered and that the node's next request starts only after it. It fails when the fallback drops the connection instead. The file also asserts the lifted service holds no literal /var/run path. Every access to the pid file goes through $installm_pidfile, so pointing that variable at the scratch tree redirects all of them, and a path written out again inside the routine would reach the host file. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
See unit/README.md and bats/README.md for the detailed rules for
each unit-test suite.