mirror of
https://github.com/xcat2/xcat-core.git
synced 2025-05-22 03:32:04 +00:00
34 lines
1013 B
ReStructuredText
34 lines
1013 B
ReStructuredText
Pull Requests
|
|
=============
|
|
|
|
Creating Pull Requests
|
|
----------------------
|
|
|
|
Once your changes are ready to be submitted to the xcat team, the easiest way to generate a pull request is from the GitHub UI.
|
|
|
|
#. Under your project, click on the "branches" link
|
|
|
|
.. image:: github-pullrequest_branch.png
|
|
|
|
#. Find the branch that contains your changes and click on the "New pull request" button
|
|
|
|
.. image:: github-create_pullrequest.png
|
|
|
|
#. Submit the pull request!
|
|
|
|
|
|
Reviewing Pull Requests as a Maintainer
|
|
---------------------------------------
|
|
|
|
When you are looking over a pull request, you can merge the changes into your own temporary branch to give the code or changes a try before merging into the parent project.
|
|
|
|
#. From the merge request, click on the ``command line instructions`` link:
|
|
|
|
.. image:: github-merge_command_line.png
|
|
|
|
#. Then under **Step 1:**, there are instruction for creating a temp branch and pulling the changes from the pull request:
|
|
|
|
.. image:: github-merge_step1.png
|
|
|
|
|