mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-24 16:54:03 +00:00
Daniel Hilst
5554b79c2d
The step that fills lib/firmware in the Ubuntu netboot initrd asked modinfo about $rootimg_dir/$module and looked a firmware name up under lib/firmware. The copy step beside it takes a module from $customdir or $pathtofiles first, and the kernel looks a firmware name up under updates/<kernel>, updates/, <kernel>/ and lib/firmware. So a custom driver reached the initrd with no firmware, even when the root image carried it, and a firmware override was left out of the initrd altogether. initrd_firmware_files now takes the module directories the copy step searches and the kernel release. It resolves each module in that order before asking modinfo, and keeps every firmware file that exists in the four directories the kernel searches, so the override still wins on the node. ubuntu_genimage_initrd_firmware.t covers both: its two new cases are red on the commit before this one. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
See unit/README.md and bats/README.md for the detailed rules for
each unit-test suite.