Daniel Hilst
4ccac9abae
dhcp_ddns_policy.t and dhcp_isc_expression_grouping.t called BAIL_OUT when a routine was missing or the plugin could not be read. prove stops every remaining file on a bail-out, so one of them hides the results of every test that would have run after it. die is just as loud and costs only its own file. Three facts in this branch were each written out in four places. That SIGHUP reports success before Kea reads the file appears in Kea.pm twice and in dhcp.pm again; that an installed node netboots when no boot file reaches it appears in BootPolicy.pm and three times in dhcp.pm; the dhcpd grouping rule appears in BootPolicy.pm and in the test header. Each now stands once, without the symptom narration and the defect history around it. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| DHCP wire tests | xCAT-test/dhcptest/ |
python3 -m unittest discover -s tests, then dhcptest run -i <nic> <conf> |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
dhcptest is the odd one out: its Python unit tests and dhcptest validate
run offline like the others, but its point is the third column -- driving real
DHCP transactions on a provisioning NIC and asserting on what came back. It
talks to the server only over the wire, so it is agnostic to which DHCP
implementation is answering and to xCAT itself.
See unit/README.md, bats/README.md and dhcptest/README.md for the
detailed rules for each suite.