* add support for syncfiles with scp
* refine logic of EXECTUTE support message non rsync filesync
* refine syncfiles
* add startsyncfile script for cumulus
* refine format, fix updatenode without options causes command to crash #5142
`rmdef` command do not help clean up the recousrces that related to
the node when removing the node. this is a technical debt. This patch
is only a work around to add -C|--cleanup option to help remove the
entries in goconserver.
On diskless SN, the nodes file of goconserver is missing when
reinstalling. This patch add a column in nodehm table to help
recover the console information on service node.
```
[root@c910f03c09k04 ~]# makegocons -q
NODE SERVER STATE
c910f03c09k05 c910f03c09k04.pok.stglabs.ibm.com error
node-7912ac1-06vag36 c910f03c09k04.pok.stglabs.ibm.com error
NODE SERVER STATE
c910f03c09k04 c910f03c09k03.pok.stglabs.ibm.com connected
[root@c910f03c09k04 ~]# rm /var/lib/goconserver/*
rm: remove regular file ‘/var/lib/goconserver/nodes.json’? y
rm: remove regular file ‘/var/lib/goconserver/nodes.json.bak’? y
[root@c910f03c09k04 ~]# service xcatd restart
Restarting xcatd (via systemctl): [ OK ]
[root@c910f03c09k04 ~]# makegocons -q
NODE SERVER STATE
c910f03c09k05 c910f03c09k04.pok.stglabs.ibm.com error
node-7912ac1-06vag36 c910f03c09k04.pok.stglabs.ibm.com error
NODE SERVER STATE
c910f03c09k04 c910f03c09k03.pok.stglabs.ibm.com connected
```
- for diskful, it will be set when leaving 'booting' stage
- for diskless, it will be set when leaving 'netbooting' stage
- for diskful reboot, it will set when (site.runpostscript=1)
- modify the document accordingly
- also modify GlobalDef.pm, but it won't have impact as the status will not be in nodeset operation.
* fix issueNode range not specified, see man page for syntax. return with no output when site.master is not set #4299
* Fix issue 4246, record rflash process in log file
* dodiscovery: better disksize - ordered by major,minor and no `\n` (#4219)
* better disksize: ordered by major,minor and no `\n`
* nodediscover:`disksize` sent correctly: no need to `split`,`join`
* general sort with explicit key columns, fix search pattern
* dodiscovery: Fix bugs
* dodiscovery: Fix ShellCheck SC2007,SC2004
* dodiscovery: simpler kcmdline parsing, disksize as IEC binary prefix
* Add test case - switch_to_dns_forward_mode
* Modify timeout of login by curl command for OpenBMC
* Add makegocons command
This patch enable goconserver service and manage the node sessions
with a new `makegocons` command.
Implement: #4215
* Refine the Cumulus Linux Section of the Doc (#4249)
* No content in the switches subdirectory in docs, remove
* Change the Network topic to Networking
* Refine and reformat the Cumulus Linux documentation
* Modify the script to build xCAT-genesis-base package (#4292)
* Verify hash ID
* change log messages
* Timeout the ntpd process if ntpd service is not running on ntpserver (#4321)
* enhance nodediscovery process: don't write "NOIP" if the node can not be resloved to an IP (#3995)
* enhance nodediscovery process, if only 1 mac and have \*NOIP\* append, don't write mac table and don't generate dhcp lease entry
* Enhance PR 3995: enhance nodediscovery process: don't write "NOIP" if the node can not be resloved to an IP
* modified depending on comments
* natural_sort_cmp: recursion to iterative implementation (#4314)
* natural_sort_cmp: recursion to iterative implementation
* natural_sort_cmp: correct prototype with parameters, as per `man perlfunc`
* Task 3339, rspconfig ip/netmask/gateway/vlan support
* * Minor enhance on xcatperftest to put all logs into one file
* Fix a bug in simulatorctl.sh, and it cause the script cannot be found
* modified depending on comments
* QA list for makehosts (#4284)
* QA list for makehosts
* Fix some bus in makegocons
* Revise test case - switch_to_dns_forward_mode
* Enhancements after the review
* Use IO::Socket to check BMC console port
* Revise test case - switch_to_dns_forward_mode
* modified depending on comments
* Add messages to inform the user of the general action started via xCAT for flashing firmware
* Fix bug, anything in the functional array is the one that's really active, priority will not be 0 if there is pending firmware
* Fix 4338, remove all of in child process
* fix issue #4354 :The XCATTEST_CN in xcattest can not detect HCP as config file (#4355)
* Fix#4330, close the socket
* Add image name to /opt/xcat/xcatinfo on compute node (#4359)
* Integrate congo console from goconserver with rcons
Enhance the original implement of rcons to support goconserver.
`rcons` will help the user choose from one of the console backend
service based on the console server status of management node.
Implement #4216
* Fix 4363 - discovery broken (#4364)
* do not set exit_code to 1 when the clock is not synced before the timeout (#4362)
* Fix check for MTM values with spaces
* modified depending on comments
* rspconfig admin_password for OpenBMC
* Fix merging in xdcpmerge.sh (#4328)
* Fixes in xdcpmerge.sh
Two fixes:
1. The grep pattern when finding duplicate usernames is missing ":" at the end. So, for example user "test" would also match "test2, etc.". Adding the ":" delimiter fixes the issue.
2. Another issue happens when the file to be merged is a superset of the files on the nodes. For example, if a new user is added and entire passwd file (that is otherwise identical) is sent to be merged. In this case, the $filebackup.nodups file, i.e. the original file with duplicates removed, becomes empty and the condition "if [ -s "$filebackup.nodups" ]" does not execute. Then the merged file ends up being original file with the merge file fully appended, clearly not what was intended.
This is solved by changing the condition to check for file existence "-a" rather then for size. Additionally, I also turn the logic around so that the duplicates are removed from the merge file and then added to the original file. I think this makes logic a bit cleaner and also ensures that existing entries are not reordered or changed in any way.
* Streamlining previous commit
Adjustment to previous commit, streamlining and simplifying logic. Once $mergefile.nodups is created, just concatenate it the original file.
* Update to xdcpmerge
No need to copy $filebackup to $curfile, they are the same.
* Modify for debug conveniently
* add new cases and delete outdated test cases
* Modify genesis build script for centos x86_64
* Add space between at and the time
* Add a print out of the firmware levels for the various UT cases
* Add unit test cases for rspconfig
* rspconfig fix for set hostname
* Enhance the testing case for rspconfig setting hostname
* modified depending on comments
* modified depending on comments
* Add %pretrans script in <lua>. Handle directory to symlink change properly. See comment #3 of https://bugs.launchpad.net/rpm/+bug/633636
* Make xCAT-genesis-base confliects with early version of xCAT-genesis-scripts
* rspconfig dump to allow admins capture logs
* Adding comment
* Improve the error message when BMC does not return a dump ID
* Improve some messages and add timestamp for downloaded dump file
* Improve the message to help Admin figure out where the file is missing
* Leave a log file there when xCAT upgrade in case to debug issue while upgrading (#4389)
* Listen on 0.0.0.0 instead of the hostname
This patch modify the configuration of `makegocons` and `rcons`
for goconserver.
`cat /etc/goconserver/server.conf`
```
global:
host: 0.0.0.0
ssl_key_file: /etc/xcat/cert/server-key.pem
ssl_cert_file: /etc/xcat/cert/server-cert.pem
ssl_ca_cert_file: /etc/xcat/cert/ca.pem
logfile: /var/log/goconserver/server.log
api:
port: 12429
console:
port: 12430
```
* Support hostname=* for openbmc
* Relay action and snmp configuration support for Coral PDU
* ddns.pm: specify the "directory" option for DNS slaves too (cf. bug #4392)
* Fix issue 4361, modify some sendmsg to message
* 1. add "makeconserver -d" to "rmdef -C", 2. add "makeconserver -C|--cleanup" to remove entries for removed nodes
* When there is a problem with the login, do not hide the message on debug mode. BMCReady does not make sense if the admin does not know how to find that state
* Change function from login_logout_request to login_request, not doing any logout here
* Check that RC is 200 to prevent unknown issues, handle the response generically
* OpenBMC rspconfig dump timeout fixes
* Fix issue 4408, modify error for rspconfig dump
* Clear all BMC Dump logs when BMC firmware flash
* modified depending on comments
* More modifications for pr 4386, to deal with the conflicts
* To handle one case which have 2 implementations, which one is for specific platform, on is for all platforms
* return when current status is RSPCONFIG_DUMP_DOWNLOAD_REQUEST
* fix issue 4417, delete 'clear next_status'
* fix issue 4353: rspconfig needs to support multiple IPs on the BMC and ignore ZeroConfigIPs
* Wait 15 seconds after OpenBMC interface with vlan tag to be activated
* Fix issue #4397: rspconfig <> hostname=xxx show error message when there is multiple network in bmc
* Some sentence modify for makeconservercf -C|--cleanup
* OpenBMC rspconfig dump better dump file name formatting
* Removed the --check and --ipsource option with PR 4258, update the man page
* Improve the message on the HTTP response
* modified depending on comments
* Only handle 404 and 504 in the login request code, defer the rest to deal_with_response()
* rflash stream support
* 1. configure ip/netmask/gateway only on the NIC whose IP match node BMC attribute, 2. add some information for LinkLocal address
* Fix confignetwork bond nic_type detection with multiple bonds
* Modified configonie --ntp command (#4436)
* Add man page for makegocons
This is the guide about how to make goconserver as
a replacement for conserver to help slove the issues reported
for conserver, like: #4043, #3543. For openbmc, the solution of
goconserver is much light-weighted than the conserver which could
help save the system resource. In addition, sshpass is not needed
for openbmc with goconserver.
Implement: #4337
* Add another key for node_info in order not to after the content of $node_info{$node}{bmc}
* enhance rflash stream
* makedhcp does not work well when all service nodes not running dhcp but disjointdhcps=1 (#4426) (#4440)
- if all service nodes not running dhcp, to treat it as disjointdhcps=0
- nodeset will send request to MN by default even if disjointdhcps=1
- Move out of the dhcp service checking from opts pre-check, and do it just before real makedhcp handling.
* rspconfig configure bmc vlan will hung because of PR 4383
* OpenBMC rspconfig dump enhancements
* Changes due to review comments
* Print debug message before login attempt
* Add warning when xCAT throttles SSL connections
* Display first [openbmc_debug] when entering openbmc.pm
* modified error msg
* Make sure credential files have a trailing newline (#4442)
* modified depending on comments
* Fix the typo in the man page of makegocons
* Update the print out based on the review comment, should not use since the regular expression is removed
* Modify the nodeset disjoint test case accordingly for #4426
* Use short hostname in rcons for goconserver
As the certificate of xcat is signed with short hostname, this
commit force to use the short hostname in the environment variable for
`congo console`.
* Fix issue 3497, make sense for reventlog msg
* Give summary after flash active when no debugmode
* Fix the issue that the IP configuration will fail if bmc attribute is a hostname
* enhance genimage for sles12sp2 (#4450)
* Add dhcp-client-identifier to lease block (#4429)
Machines that use Infiniband for PXE booting need to have the
dhcp-client-identifier set in the lease block.
Without it, they will not get the lease from the server.
* Support multiple bonds on bring-up
* modified depending on comments
* fix the check for rc to 1 on error cases
* modify response for bmcdiscover when error
* Ignore syslog error in monitorctrl when setNodeStatusAttributes (#4459)
* fix issue https://github.com/xcat2/xcat-core/issues/4411 (#4462)
* fix issue Compute nodes fail to get provisioned #4411: covert imgsrv and xcatmaster to their ip addresses in case the hostname cannot be resolved inside initrd for diskless
* More strict check to tell if it is a chroot env to avoid modify DB (#4463)
when genimage for SN image (#4365)
* issues for install license file on accton switches (#4460)
* Add test cases for rflash regular usage against openbmc
* modify depending on xuwei's comment
* add 2 more cases for option d
* enhance rflash upload message
* Do not display message for clearing dumps when only PNOR
* Display hostname even if multiple IP addresses
* modified depending on comments
* polished message
* Modify the default consoleondemand based on the global setting
This commit fix the bug that consoleondemand works incorrectly.
* modify depending on comments
* modified depending on comments
* enhance rflash error messages
* Modify documenation for servicenode attributes
* build rst file from Schema.pm by db2man
* change status back to starts
* modified depending on comments
* rm openbmcevents
* Usage and man page update for rspconfig dump
* let rflash error message flexible
* Add support for the "file -> (noderange) file" syntax in synclist with ServiceNodes (#4445)
* Add support for "file - (noderange) file" in synclist when using
hierarchical mode. Fixes#4425
This patch ensures that:
1. the synclist is correctly parsed when running on a Service Node
2. all files are synchronized to SNs in hierarchical mode
* Better test condition for #4425, addresses issue in
https://github.com/xcat2/xcat-core/pull/4445#issuecomment-349472901
* Fix issue 4477, if has node-<mac> will not create node-<mtms> for the same node
* fix issue updatenode -f loses directories when copying files to SN #4456 (#4494)
* comment from ErTao
* Crude attempt at including external configuration files in named.conf
* Fixes after the review
* Fix issue 4490, record any error when rflash active process
* add -d usage and manpage
* updatenode -F not work in hierachy env as the user name is FQDN of MN (#4484)
* updatenode -F not work in hierachy env (#4455)
- add trace when -V is enabled
- get the DSH_FROM_USERID from updatenode client
* - when 'updatenode -F' need to push SN first, using root as non-root does not have permission write to 'SNsyncfiledir'
- move the set DSH_FROM_USERID code out of the loop, and also cover remote client case.
* fix issue for command rspconfig hostname=*
* enhance rflash
* Adjust the server used for kernel/initrd and imgurl for petitboot (#4416)
- URL for kernel/initrd, get the value from below value tftpserver -> xcatmaster -> myipfn
- URL for image, get the value from below value nfsserver -> tftpserver -> xcatmaster -> myipfn
* NODE attribute didn't populate in /opt/xcat/xcatinfo after reboot (#4428)
* NODE attribute didn't populate in /opt/xcat/xcatinfo after reboot
* Get NODE from mypostscripts
* Improve the output message for reventlog, use a global variable to set PolicyFile Path
* If debug_msg is not provided, use an empty string
* Check for LinkLocal as well as 169.254 IP address
* Fix issue 4507, add parameter check for rspconfig admin_passwd
* record more information when rflash upload error
* Fix the error when using array ref in updatenode with old version perl, it is introduced by PR#4484 (#4518)
* Do not restart conserver if goconserver was started
If goconserver was enabled, do not start conserver when restart
xcatd on service node.
* remove the /etc/localtime before copy timezone file
* Use CONGO_CLIENT_TYPE to tell goconserver the source of client (#4501)
goconserver could send back message based on the client type
this commit set CONGO_CLIENT_TYPE to xcat to make the message
from goconserver more friendly.
* add rflash -d doc
* only ignore 169.254.x.x for OpenBMC
* Fix issue 4513, print out better error msg for reventlog -s
* Modify or add openbmc test cases or bundle
* add test cases for updatenode -f/F in hierarchy environment, covers issues #4456,#4455 and PR #4425 (#4500)
