From 371a15686b75533da6ae8c0c3103202cee7f118b Mon Sep 17 00:00:00 2001
From: Mark Gurevich <gurevich@us.ibm.com>
Date: Fri, 17 Apr 2020 11:37:43 -0400
Subject: [PATCH] Verify second parameter to rcons is a host

---
 xCAT-client/bin/rcons | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/xCAT-client/bin/rcons b/xCAT-client/bin/rcons
index 610b20101..1fc8418b5 100755
--- a/xCAT-client/bin/rcons
+++ b/xCAT-client/bin/rcons
@@ -36,11 +36,17 @@ for parameter in $@; do
     if [ $param_n -eq 2 ]; then
         if [ "$parameter" != "-f" ] && [ "$parameter" != "-s" ]; then
             CONSERVER=$parameter
+            # verify the specified CONSERVER can be resolved
+            host $CONSERVER > /dev/null 2>&1
+            if [ $? -ne 0 ]; then
+                echo "Error: cannot recognize parameter or conserver host \"$parameter\". Run \"rcons -h\" for usage."
+                exit 1
+            fi
         fi
     fi
 
     if [ $param_n -ge 2 ]; then
-        if [ "$parameter" = "-f" ] || [ "$parameter" = "-s" ]; then
+        if [ "$parameter" == "-f" ] || [ "$parameter" == "-s" ]; then
             if [ -z "$FORCE" ]; then
                 FORCE=$parameter
             elif [ "$FORCE" != "$parameter" ]; then
@@ -52,7 +58,7 @@ for parameter in $@; do
 
     if [ $param_n -ge 3 ]; then
         if [ "$parameter" != "-f" ] && [ "$parameter" != "-s" ]; then
-            echo "Error: cannot recognize parameter \"$parameter\"."
+            echo "Error: cannot recognize parameter \"$parameter\". Run \"rcons -h\" for usage."
             exit 1
         fi
     fi