xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2025-06-13 01:40:26 +00:00
Code Issues Releases Wiki Activity

Avoid of circular reference in a loop of rinstall (#3121)

Browse Source 
This is a temporary fix for getadapter which will hang forever if
error happens in `rinstall stage`. The root cause is the circular
reference in `runxcmd`. As global variable `$::xcmd_outref` and
`%::xcmd_outref_hash` are used to save the output message, if the
plugin command are called with runxcmd and the plugin called also
calls another plugin with `runxcmd`, the circular reference will happen.
In this situation, if the output reponse is used in a iterator,
like:
```
   foreach my $line (@$res) {
      xCAT::MsgUtils->message("I", $rsp, $callback);
```
`$res` points to the global variable, and `MsgUtils->message` in the
runxcmd calls also add the value in the global variable, as the
iter object is changed, the loop will not be terminated.

This patch can not solve the circular reference problem, it is just
a workaround to avoid infinite loop.

Some known issues: the error message will print twice as the
`MsgUtils->message` called in runxcmd. But we can not simply remove
it as the plugin may not be called with `runxcmd`.

Error message example:

```
Error: frame10node10: mgt configuration can not be found.
frame10node10: Unable to identify plugin for this command, check relevant tables: noderes.netboot
frame10node10: Unable to identify plugin for this command, check relevant tables: noderes.netboot
Failed to run 'nodeset' against the following nodes: frame10node10
Error: failed to run command: rinstall frame10node10 runcmd=getadapter
```
partial-fix: #3046
This commit is contained in:
chenglch
2017-06-08 11:21:26 +08:00
committed by yangsong
parent cccf4b783f
commit d9d0cfd42c
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
xCAT-server/lib/xcat/plugins/rinstall.pm
View File

@ -351,7 +351,9 @@ sub rinstall {
# We got an error with the nodeset
my @successnodes;
my @failurenodes;
foreach my $line (@$res) {
# copy into a temporary variable to avoid of circular reference
my @lines = @$res;
foreach my $line (@lines) {
$rsp->{data}->[0] = $line;
if (($line =~ /: install/) or ($line =~ /: netboot/)) {
my $successnode;
@ -414,7 +416,6 @@ sub rinstall {
},
$subreq, -1, 1);
$rc = $::RUNCMD_RC;
my $rsp = {};
if ($VERBOSE) {
@ -427,7 +428,9 @@ sub rinstall {
# We got an error with the rnetboot
my @failurenodes;
foreach my $line (@$res) {
# copy into a temporary variable to avoid of circular reference
my @lines = @$res;
foreach my $line (@lines) {
$rsp->{data}->[0] = $line;
if ($line =~ /: Success/) {
my $successnode;
@ -491,7 +494,9 @@ sub rinstall {
# We got an error with the rsetboot
my @successnodes;
my @failurenodes;
foreach my $line (@$res) {
# copy into a temporary variable to avoid of circular reference
my @lines = @$res;
foreach my $line (@lines) {
$rsp->{data}->[0] = $line;
if ($line =~ /: Network/) {
my $successnode;
@ -550,7 +555,9 @@ sub rinstall {
unless ($rc == 0) {
# We got an error with the rpower
my @failurenodes;
foreach my $line (@$res) {
# copy into a temporary variable to avoid of circular reference
my @lines = @$res;
foreach my $line (@lines) {
$rsp->{data}->[0] = $line;
if (($line =~ /: on reset/) or ($line =~ /: off on/)) {
my $successnode;