From d861f68995d73f27dce5354c660798a07f6973e2 Mon Sep 17 00:00:00 2001 From: Mark Gurevich Date: Mon, 5 Jun 2017 10:56:59 -0400 Subject: [PATCH] Sync usage, man and code for ipmi rvitals --- .../ppc64le/management/basic/rcons.rst | 2 +- .../admin-guides/references/man1/rvitals.1.rst | 8 +++++++- perl-xCAT/xCAT/Usage.pm | 2 +- xCAT-client/pods/man1/rvitals.1.pod | 6 +++++- xCAT-server/lib/xcat/plugins/ipmi.pm | 16 ++++++++-------- 5 files changed, 22 insertions(+), 12 deletions(-) diff --git a/docs/source/guides/admin-guides/manage_clusters/ppc64le/management/basic/rcons.rst b/docs/source/guides/admin-guides/manage_clusters/ppc64le/management/basic/rcons.rst index 6fcd77a1d..396880103 100644 --- a/docs/source/guides/admin-guides/manage_clusters/ppc64le/management/basic/rcons.rst +++ b/docs/source/guides/admin-guides/manage_clusters/ppc64le/management/basic/rcons.rst @@ -46,7 +46,7 @@ The xCAT ``rcons`` command relies on conserver (http://www.conserver.com/). The OpenBMC Specific -``````````````` +```````````````` #. For OpenBMC managed servers, the root user must be able to ssh passwordless to the BMC for the ``rcons`` function to work. diff --git a/docs/source/guides/admin-guides/references/man1/rvitals.1.rst b/docs/source/guides/admin-guides/references/man1/rvitals.1.rst index c6a84c704..7fa7e62d6 100644 --- a/docs/source/guides/admin-guides/references/man1/rvitals.1.rst +++ b/docs/source/guides/admin-guides/references/man1/rvitals.1.rst @@ -60,7 +60,7 @@ OpenPOWER (IPMI) specific: ========================== -\ **rvitals**\ \ *noderange*\ [\ **temp | voltage | wattage | fanspeed | power | leds | all**\ ] +\ **rvitals**\ \ *noderange*\ [\ **temp | voltage | wattage | fanspeed | power | leds | chassis | all**\ ] OpenPOWER (OpenBMC) specific: @@ -140,6 +140,12 @@ Processor for a single or range of nodes and groups. +\ **chassis**\ + + Retrieves chassis status. + + + \ **altitude**\ Retrieves altitude related attributes. diff --git a/perl-xCAT/xCAT/Usage.pm b/perl-xCAT/xCAT/Usage.pm index f7db5790b..b93c5d788 100755 --- a/perl-xCAT/xCAT/Usage.pm +++ b/perl-xCAT/xCAT/Usage.pm @@ -82,7 +82,7 @@ my %usage = ( BMC specific: rvitals noderange {temp|voltage|wattage|fanspeed|power|leds|all} OpenPOWER (IPMI) specific: - rvitals noderange [temp|voltage|wattage|fanspeed|power|leds|all] + rvitals noderange [temp|voltage|wattage|fanspeed|power|leds|chassis|all] OpenPOWER (OpenBMC) specific: rvitals noderange [temp|voltage|wattage|fanspeed|power|altitude|all] MIC specific: diff --git a/xCAT-client/pods/man1/rvitals.1.pod b/xCAT-client/pods/man1/rvitals.1.pod index bb7fec138..fb246eb40 100644 --- a/xCAT-client/pods/man1/rvitals.1.pod +++ b/xCAT-client/pods/man1/rvitals.1.pod @@ -28,7 +28,7 @@ B I {B|B|B|B|B|B I [B|B|B|B|B|B|B] +B I [B|B|B|B|B|B|B|B] =head2 OpenPOWER (OpenBMC) specific: @@ -79,6 +79,10 @@ Retrieves rack environmentals. Retrieves LEDs status. +=item B + +Retrieves chassis status. + =item B Retrieves altitude related attributes. diff --git a/xCAT-server/lib/xcat/plugins/ipmi.pm b/xCAT-server/lib/xcat/plugins/ipmi.pm index 59f70d20a..a096071a7 100644 --- a/xCAT-server/lib/xcat/plugins/ipmi.pm +++ b/xCAT-server/lib/xcat/plugins/ipmi.pm @@ -6506,30 +6506,30 @@ sub vitals { $sensor_filters{leds} = 1; $doall = 1; } - if (grep /temp/, @textfilters) { + if (grep /^temp$/, @textfilters) { $sensor_filters{0x01} = 1; } - if (grep /volt/, @textfilters) { + if (grep /^voltage$/, @textfilters) { $sensor_filters{0x02} = 1; } - if (grep /watt/, @textfilters) { + if (grep /^wattage$/, @textfilters) { $sensor_filters{watt} = 1; } - if (grep /fan/, @textfilters) { + if (grep /^fanspeed$/, @textfilters) { $sensor_filters{0x04} = 1; } - if (grep /power/, @textfilters) { #power does not really include energy, but most people use 'power' to mean both + if (grep /^power$/, @textfilters) { #power does not really include energy, but most people use 'power' to mean both $sensor_filters{0x03} = 1; $sensor_filters{powerstate} = 1; $sensor_filters{energy} = 1; } - if (grep /energy/, @textfilters) { + if (grep /^energy$/, @textfilters) { $sensor_filters{energy} = 1; } - if (grep /led/, @textfilters) { + if (grep /^leds$/, @textfilters) { $sensor_filters{leds} = 1; } - if (grep /chassis/, @textfilters) { + if (grep /^chassis$/, @textfilters) { $sensor_filters{chassis} = 1; } unless (keys %sensor_filters) {