From d68a68a260bb2f957c9070075a50b4de5fa59d69 Mon Sep 17 00:00:00 2001 From: XuWei Date: Fri, 23 Feb 2018 02:26:42 -0500 Subject: [PATCH] modified depending on comments --- .../lib/python/agent/hwctl/executor/openbmc_bmcconfig.py | 1 + xCAT-openbmc-py/lib/python/agent/hwctl/openbmc_client.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/xCAT-openbmc-py/lib/python/agent/hwctl/executor/openbmc_bmcconfig.py b/xCAT-openbmc-py/lib/python/agent/hwctl/executor/openbmc_bmcconfig.py index 1a9a1727c..a3240bc48 100644 --- a/xCAT-openbmc-py/lib/python/agent/hwctl/executor/openbmc_bmcconfig.py +++ b/xCAT-openbmc-py/lib/python/agent/hwctl/executor/openbmc_bmcconfig.py @@ -75,6 +75,7 @@ class OpenBMCBmcConfigTask(ParallelNodesCommand): if not dump_dict: self.callback.info('%s: No attributes returned from the BMC.' % node) + return dump_info keys = dump_dict.keys() keys.sort() diff --git a/xCAT-openbmc-py/lib/python/agent/hwctl/openbmc_client.py b/xCAT-openbmc-py/lib/python/agent/hwctl/openbmc_client.py index 39297f2c8..29169ff8a 100644 --- a/xCAT-openbmc-py/lib/python/agent/hwctl/openbmc_client.py +++ b/xCAT-openbmc-py/lib/python/agent/hwctl/openbmc_client.py @@ -327,7 +327,7 @@ class OpenBMCRest(object): raise if not response: - self._print_record_log('No response received', cmd=cmd) + self._print_record_log('No response received for command %s' % request_cmd, cmd=cmd) return True self._print_record_log(str(response.status_code), cmd=cmd) @@ -603,7 +603,7 @@ class OpenBMCRest(object): return dump_dict except KeyError: - error = 'Error: Received wrong format response: %s' % inventory_data + error = 'Error: Received wrong format response: %s' % dump_data raise SelfServerException(error) def download_dump(self, download_id, file_path):