From b0f87b2b9913e8d590cdf75bc38da534176c1e4d Mon Sep 17 00:00:00 2001 From: Daniel Hilst <392820+dhilst@users.noreply.github.com> Date: Mon, 14 Sep 2026 08:34:35 -0300 Subject: [PATCH] style(xcat-core): the netplan test comment traces the failure across four layers The comment on the use-domains assertion in ubuntu_subiquity_installnic.t followed the missing search domain from systemd-networkd through updateflag.awk to a node stuck in postbooting. The assertion below it already names what is checked. The comment now carries the one fact the code does not show: networkd defaults UseDomains to no. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com> --- xCAT-test/unit/ubuntu_subiquity_installnic.t | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/xCAT-test/unit/ubuntu_subiquity_installnic.t b/xCAT-test/unit/ubuntu_subiquity_installnic.t index 876915e9a..fe6b24079 100644 --- a/xCAT-test/unit/ubuntu_subiquity_installnic.t +++ b/xCAT-test/unit/ubuntu_subiquity_installnic.t @@ -139,9 +139,7 @@ SKIP: { "the netplan written for $case->{name} matches the resolved values"); # systemd-networkd defaults UseDomains to no, so a netplan carrying dhcp4: true alone - # takes the DNS server from DHCP and drops the offered domain-search. The node then - # resolves no single-label name: updateflag.awk runs "$MASTER 3002" with the short - # management node name, cannot resolve it, and the node never leaves postbooting. + # drops the search domain DHCP offers, and no single-label name resolves on the node. like($netplan, qr/^\s+use-domains: true$/m, "the netplan for $case->{name} asks networkd to use the DHCP search domain"); }