From 593a6215e88e7a427f0269a99dc2623f12fb067a Mon Sep 17 00:00:00 2001
From: immarvin <yangsbj@cn.ibm.com>
Date: Thu, 16 Nov 2017 01:31:59 -0500
Subject: [PATCH] fix issueNode range not specified, see man page for syntax.
 return with no output when site.master is not set #4299

---
 perl-xCAT/xCAT/ServiceNodeUtils.pm | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/perl-xCAT/xCAT/ServiceNodeUtils.pm b/perl-xCAT/xCAT/ServiceNodeUtils.pm
index c27601874..13051df88 100755
--- a/perl-xCAT/xCAT/ServiceNodeUtils.pm
+++ b/perl-xCAT/xCAT/ServiceNodeUtils.pm
@@ -509,8 +509,11 @@ sub get_ServiceNode
 
     # get site.master this will be the default
     my $master = xCAT::TableUtils->get_site_Master();
-    $noderestab = xCAT::Table->new('noderes');
+    unless($master){
+        xCAT::MsgUtils->message('SW',"site.master is not set!\n");
+    }
 
+    $noderestab = xCAT::Table->new('noderes');
     unless ($noderestab)    # no noderes table, use default site.master
     {
         xCAT::MsgUtils->message('I',
@@ -548,7 +551,7 @@ sub get_ServiceNode
                     my $key = $rec->{$snattribute};
                     push @{ $snhash{$key} }, $node;
                 }
-                else                                  # use site.master
+                elsif($master)                                  # use site.master
                 {
                     push @{ $snhash{$master} }, $node;
                 }
@@ -595,7 +598,7 @@ sub get_ServiceNode
                             my $key = $rec->{$snattribute};
                             push @{ $snhash{$key} }, $node;
                         }
-                        else
+                        elsif($master)
                         {                                     # use site.master
                             push @{ $snhash{$master} }, $node;
                         }
@@ -631,7 +634,7 @@ sub get_ServiceNode
                                 my $key = $rec->{$snattribute};
                                 push @{ $snhash{$key} }, $node;
                             }
-                            else
+                            elsif($master)
                             {    # use site.master
                                 push @{ $snhash{$master} }, $node;
                             }
@@ -675,7 +678,7 @@ sub get_ServiceNode
                                 my $key = $sn->{$snattribute};
                                 push @{ $snhash{$key} }, $node;
                             }
-                            else
+                            elsif($master)
                             {          # no service node use master
                                 push @{ $snhash{$master} }, $node;
                             }