From 75c0af53732080924d06eab5f4e797f38551ac3e Mon Sep 17 00:00:00 2001 From: Daniel Hilst <392820+dhilst@users.noreply.github.com> Date: Tue, 15 Sep 2026 21:11:00 -0300 Subject: [PATCH] fix(xcat-core): debian_install_prescript.t passes when the file it reads is missing debian_install_prescript.t called plan skip_all when xCAT-server/lib/xcat/plugins/debian.pm was absent, so a checkout that lost the file reported 0 tests and exit 0. A test that cannot fail measures nothing. Die instead, which is what makentp_ntp_deps.t already does for setupntp. With xCAT-server/lib/xcat/plugins/debian.pm moved aside the file now exits 2 and prints "debian.pm not found"; before this change it exited 0 and printed "1..0 # SKIP debian.pm not found". With the file present the test passes either way. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com> --- xCAT-test/unit/debian_install_prescript.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xCAT-test/unit/debian_install_prescript.t b/xCAT-test/unit/debian_install_prescript.t index db20da711..bc5decd21 100644 --- a/xCAT-test/unit/debian_install_prescript.t +++ b/xCAT-test/unit/debian_install_prescript.t @@ -17,7 +17,7 @@ use Test::More; use lib "$FindBin::Bin/../../perl-xCAT"; use lib "$FindBin::Bin/../../xCAT-server/lib/perl"; my $plugin = "$FindBin::Bin/../../xCAT-server/lib/xcat/plugins/debian.pm"; -plan skip_all => 'debian.pm not found' unless -r $plugin; +die "debian.pm not found\n" unless -r $plugin; eval { require $plugin; 1 } or plan skip_all => "could not load debian.pm: $@"; can_ok('xCAT_plugin::debian', 'install_prescript')