diff --git a/perl-xCAT/xCAT/Utils.pm b/perl-xCAT/xCAT/Utils.pm index aac6da437..bb3827a16 100644 --- a/perl-xCAT/xCAT/Utils.pm +++ b/perl-xCAT/xCAT/Utils.pm @@ -2201,7 +2201,7 @@ sub CheckVersion my $index = 0; my $max_index = ($len_a > $len_b) ? $len_a : $len_b; - for ($index = 0 ; $index <= $max_index ; $index++) + for ($index = 0 ; $index < $max_index ; $index++) { my $val_a = ($len_a < $index) ? 0 : $a[$index]; my $val_b = ($len_b < $index) ? 0 : $b[$index]; diff --git a/xCAT-server/lib/xcat/plugins/ddns.pm b/xCAT-server/lib/xcat/plugins/ddns.pm index d1e6f1fff..ab0414d88 100644 --- a/xCAT-server/lib/xcat/plugins/ddns.pm +++ b/xCAT-server/lib/xcat/plugins/ddns.pm @@ -14,7 +14,6 @@ use xCAT::SvrUtils; use Socket; use Fcntl qw/:flock/; use Data::Dumper; -use version; # This is a rewrite of DNS management using nsupdate rather than # direct zone mangling @@ -1286,7 +1285,7 @@ sub update_namedconf { my $bind_version_cmd="/usr/sbin/named -v | cut -d' ' -f2 | grep -Eo '[0-9]+\.[0-9]+\.[0-9]+'"; my @bind_version =xCAT::Utils->runcmd($bind_version_cmd, 0); # Turn off DNSSEC if running with bind vers 9.16.6 or higher - if ((scalar @bind_version > 0) && (version->parse($bind_version[0]) >= version->parse(9.16.6))) { + if ((scalar @bind_version > 0) && (xCAT::Utils::CheckVersion($bind_version[0], "9.16.6") >= 0)) { push @newnamed, "\tdnssec-enable no;\n"; push @newnamed, "\tdnssec-validation no;\n"; }