From c0ef730ec427e9ee20da3b1fb2500b6593783385 Mon Sep 17 00:00:00 2001
From: Michael Brown <mcb30@etherboot.org>
Date: Thu, 11 Jan 2007 04:46:41 +0000
Subject: [PATCH] Fix bug in buffer.c, add buffer mini-unit test.

---
 src/core/buffer.c      |  6 ++---
 src/tests/buffertest.c | 54 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 57 insertions(+), 3 deletions(-)
 create mode 100644 src/tests/buffertest.c

diff --git a/src/core/buffer.c b/src/core/buffer.c
index be4c6055..91df7b66 100644
--- a/src/core/buffer.c
+++ b/src/core/buffer.c
@@ -80,21 +80,21 @@ struct buffer_free_block {
  * @ret block		Next free block descriptor
  * @ret rc		Return status code
  *
- * Set @c block->next=buffer->free before first call to
+ * Set @c block->next=buffer->fill before first call to
  * get_next_free_block().
  */
 static int get_next_free_block ( struct buffer *buffer,
 				 struct buffer_free_block *block ) {
 
 	/* Check for end of buffer */
-	if ( block->end >= buffer->len )
+	if ( block->next >= buffer->len )
 		return -ENOENT;
 
 	/* Move to next block */
 	block->start = block->next;
 	if ( block->start >= buffer->free ) {
 		/* Final block; no in-band descriptor */
-		block->end = buffer->len;
+		block->next = block->end = buffer->len;
 	} else {
 		/* Retrieve block descriptor */
 		copy_from_phys ( block, ( buffer->addr + block->start ),
diff --git a/src/tests/buffertest.c b/src/tests/buffertest.c
new file mode 100644
index 00000000..c1cb3772
--- /dev/null
+++ b/src/tests/buffertest.c
@@ -0,0 +1,54 @@
+#include <assert.h>
+#include <gpxe/buffer.h>
+
+
+struct buffer_test {
+	struct buffer buffer;
+	const char *source;
+	size_t source_len;
+	char *dest;
+	size_t dest_len;
+};
+
+static int test_fill_buffer ( struct buffer_test *test,
+			      size_t start, size_t end ) {
+	const void *data = ( test->source + start );
+	size_t len = ( end - start );
+
+	assert ( end <= test->source_len );
+	assert ( end <= test->dest_len );
+
+	fill_buffer ( &test->buffer, data, start, len );
+	assert ( memcmp ( ( test->dest + start ), data, len ) == 0 );
+	assert ( test->buffer.free >= end );
+	return 0;
+}
+
+int test_buffer ( void ) {
+	char source[123];
+	char dest[123];
+	struct buffer_test test;
+
+	memset ( &test, 0, sizeof ( test ) );
+	test.source = source;
+	test.source_len = sizeof ( source );
+	test.dest = dest;
+	test.dest_len = sizeof ( dest );
+	test.buffer.addr = virt_to_phys ( dest );
+	test.buffer.len = sizeof ( dest );
+
+	test_fill_buffer ( &test,  20,  38 );
+	test_fill_buffer ( &test,  60,  61 );
+	test_fill_buffer ( &test,  38,  42 );
+	test_fill_buffer ( &test,  42,  60 );
+	test_fill_buffer ( &test,  16,  80 );
+	test_fill_buffer ( &test,   0,  16 );
+	test_fill_buffer ( &test,  99, 123 );
+	test_fill_buffer ( &test,  80,  99 );
+
+	assert ( test.buffer.fill == sizeof ( source ) );
+	assert ( test.buffer.free == sizeof ( source ) );
+	assert ( memcmp ( source, dest, sizeof ( source ) ) == 0 );
+
+	return 0;
+}