xCAT/xNBA
2
0
Fork 0
mirror of https://github.com/xcat2/xNBA.git synced 2024-11-25 02:50:17 +00:00
Code Issues Projects Releases Wiki Activity

Correctly remove icmp echo reply

Browse Source 
Continuing the tradition of being stingy with neighbor table entries.
ICMP echo requests are common stray traffic in some environments and
stray responses are not actually a good indicator of what those
services are hoping to find anyway.
This commit is contained in:
Jarrod Johnson 2014-07-02 10:57:10 -04:00
parent 805687b7b9
commit a91b5e2200
1 changed files with 1 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/net/icmp.c
View File

@ -125,33 +125,6 @@ int icmp_tx_echo_request ( struct io_buffer *iobuf,
return 0;
}
/**
* Transmit ICMP echo reply
*
* @v iobuf I/O buffer
* @v st_dest Destination socket address
* @ret rc Return status code
*/
static int icmp_tx_echo_reply ( struct io_buffer *iobuf,
struct sockaddr_tcpip *st_dest,
struct icmp_echo_protocol *echo_protocol ) {
/*
struct icmp_echo *echo = iobuf->data;
int rc;
/* Set type */
echo->icmp.type = echo_protocol->reply;
/* Transmit reply */
DBGC ( icmpcol ( st_dest ), "ICMP TX echo reply id %04x seq %04x\n",
ntohs ( echo->ident ), ntohs ( echo->sequence ) );
if ( ( rc = icmp_tx_echo ( iobuf, st_dest, echo_protocol ) ) != 0 )
return rc;
*/
return 0;
}
/**
* Process a received ICMP echo request
*
@ -164,7 +137,7 @@ int icmp_rx_echo_request ( struct io_buffer *iobuf,
struct sockaddr_tcpip *st_src,
struct icmp_echo_protocol *echo_protocol ) {
struct icmp_echo *echo = iobuf->data;
int rc;
(void)(echo_protocol);
/* Sanity check */
if ( iob_len ( iobuf ) < sizeof ( *echo ) ) {
@ -177,10 +150,6 @@ int icmp_rx_echo_request ( struct io_buffer *iobuf,
DBGC ( icmpcol ( st_src ), "ICMP RX echo request id %04x seq %04x\n",
ntohs ( echo->ident ), ntohs ( echo->sequence ) );
/* Transmit echo reply */
if ( ( rc = icmp_tx_echo_reply ( iobuf, st_src, echo_protocol ) ) != 0 )
return rc;
return 0;
}