xCAT/xNBA
2
0
Fork 0
mirror of https://github.com/xcat2/xNBA.git synced 2025-02-06 22:11:57 +00:00
Code Issues Projects Releases Wiki Activity

[script] Avoid using stack-allocated memory in process_line()

Browse Source 
Script lines can be arbitrarily long; allocate on the heap rather than
on the stack.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown 2012-04-23 22:42:10 +01:00
parent de2616165b
commit a026a27f04
1 changed files with 15 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/image/script.c
View File

@ -58,6 +58,7 @@ static int process_script ( struct image *image,
int ( * terminate ) ( int rc ) ) {
off_t eol;
size_t len;
char *line;
int rc;
script_offset = 0;
@ -71,23 +72,23 @@ static int process_script ( struct image *image,
eol = image->len;
len = ( eol - script_offset );
/* Copy line, terminate with NUL, and execute command */
{
char cmdbuf[ len + 1 ];
/* Allocate buffer for line */
line = zalloc ( len + 1 /* NUL */ );
if ( ! line )
return -ENOMEM;
copy_from_user ( cmdbuf, image->data,
script_offset, len );
cmdbuf[len] = '\0';
DBG ( "$ %s\n", cmdbuf );
/* Copy line */
copy_from_user ( line, image->data, script_offset, len );
DBG ( "$ %s\n", line );
/* Move to next line */
script_offset += ( len + 1 );
/* Move to next line */
script_offset += ( len + 1 );
/* Process line */
rc = process_line ( cmdbuf );
if ( terminate ( rc ) )
return rc;
}
/* Process and free line */
rc = process_line ( line );
free ( line );
if ( terminate ( rc ) )
return rc;
} while ( script_offset < image->len );