From 09695f7be98ab96204e570f95aeb9192e4c3a9f6 Mon Sep 17 00:00:00 2001 From: Michael Brown Date: Thu, 3 Mar 2011 17:13:44 +0000 Subject: [PATCH] [settings] Avoid fetch_string_setting_copy() leaving an uninitialised pointer For consistency with other functions in the fetch_setting() family, ensure that fetch_string_setting_copy() always initialises the pointer to the fetched setting even if fetching fails. Signed-off-by: Michael Brown --- src/core/settings.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/core/settings.c b/src/core/settings.c index da662e61..1f22ea45 100644 --- a/src/core/settings.c +++ b/src/core/settings.c @@ -632,6 +632,8 @@ int fetch_string_setting_copy ( struct settings *settings, int len; int check_len = 0; + *data = NULL; + len = fetch_setting_len ( settings, setting ); if ( len < 0 ) return len;