After some contemplation, I realized that given the underlying behavior of 'wait_for_rsp', that
synchronous and asynchronous calls play well with each other. The pattern of considering an 'onlogon'
function as running in a sort of greenthread works well and leads to much more comprehensible code
for the average person. While removing those arguments, the module contents were reorganized to
serve as an example of how more straightforward code written in this fashion may be.
Change-Id: I9c83660e4d3c68ad8ae0c016a3377b2a0e7ee6ec
Previously the ipmi session was using time.time(). This means
that retries and keepalives could be thrown off by things like ntp
or manual time corrections.
Ideally, we'd use the baked in time.monotonic(), but that doesn't exist
aside from python 3.3
Change-Id: Ia00026cef6df214f9463909309de44767c3752b5
Assure that a live session shows activity at least once every 25-29.9 seconds.
The interval is randomized to mitigate risk of some synchronized activity
bringing on a wave of activity all at once. The spec indicated timeout is
'about' 60 seconds by default, but an implementation could lower it to 30
seconds within reason within the constraints of the spec.
Change-Id: I74dc78757b11571c23cb309c99eee667787ffc79
I realized that I had never pushed __init__.py for private.
While doing tests locally, I noticed that the pep changes broke at least one
place in code, correct that.
Change-Id: Ia31cb8a75a7109a6d002524e08ef335e1c5018d4
Rename '_pack_payload' in private module to 'send_payload' as it is more
descriptive of what is happening and will be called by console.py
Change-Id: Ifa70d269c8a1e37cc5b6466845931f22cd97d6c3
Ran autopep8 on the four .py files in this module.
Manully fixed many additional pep8 errors as well,
Turned some long-line-comments into proper NOTE lines,
but there are more to do...
Change-Id: I657ba037863860ec3956150931c2c0e41085bd63
