xCAT/pyghmi
2
0
Fork 0
mirror of https://opendev.org/x/pyghmi synced 2025-01-27 19:37:44 +00:00
Code Issues Projects Releases Wiki Activity

Fix cyclic references in SDR

Browse Source 
SDR and SDR entries had a cyclic reference to ipmicmd.  Weaken
it so that it won't cause issues (whether real or just
complicating output of guppy)

Change-Id: Iad9c9726026f46c9a104c4a7464fad9b17d336ea
This commit is contained in:
Jarrod Johnson 2016-04-04 08:12:17 -04:00
parent b9f50792d7
commit 9b547cfb5a
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pyghmi/ipmi/sdr.py
View File

@ -34,6 +34,7 @@ import pyghmi.constants as const
import pyghmi.exceptions as exc
import pyghmi.ipmi.private.constants as ipmiconst
import struct
import weakref
TYPE_UNKNOWN = 0
TYPE_SENSOR = 1
@ -251,7 +252,7 @@ class SDREntry(object):
# ignore record id for now, we only care about the sensor number for
# moment
self.reportunsupported = reportunsupported
self.ipmicmd = ipmicmd
self.ipmicmd = weakref.ref(ipmicmd)
if entrybytes[2] != 0x51:
# only recognize '1.5', the only version defined at time of writing
raise NotImplementedError
@ -584,7 +585,7 @@ class SDR(object):
:param ipmicmd: A Command class object
"""
def __init__(self, ipmicmd):
self.ipmicmd = ipmicmd
self.ipmicmd = weakref.ref(ipmicmd)
self.sensors = {}
self.fru = {}
self.read_info()