xCAT/pyghmi
2
0
Fork 0
mirror of https://opendev.org/x/pyghmi synced 2025-01-28 11:57:34 +00:00
Code Issues Projects Releases Wiki Activity

Fix behavior of unavailable sensors in redfish

Browse Source 
In IPMI, we provided a reasonably viable result for unavailable sensors.
Set unavailable attribute on the reading to indicate this in redfish.

Change-Id: I841dbc8c9660abd84ee59eab9c3006dc51949de3
This commit is contained in:
Jarrod Johnson 2019-08-08 15:10:32 -04:00
parent 9cb6cebf26
commit 6a7df11e3c
1 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
pyghmi/redfish/command.py
View File

@ -1392,15 +1392,28 @@ class Command(object):
if sensor['type'] == 'Fan':
for fan in reading['Fans']:
if fan['Name'] == sensor['name']:
return SensorReading(None, sensor, value=fan['Reading'], units=fan['ReadingUnits'])
val = fan.get('Reading', None)
unavail = val is None
units = fan.get('ReadingUnits', None)
return SensorReading(
None, sensor, value=val, units=units,
unavailable=unavail)
elif sensor['type'] == 'Temperature':
for temp in reading['Temperatures']:
if temp['Name'] == sensor['name'] and 'ReadingCelsius' in temp:
return SensorReading(None, sensor, value=temp['ReadingCelsius'], units='°C')
val = temp.get('ReadingCelsius', None)
unavail = val is None
return SensorReading(
None, sensor, value=val, units='°C',
unavailable=unavail)
elif sensor['type'] == 'Voltage':
for volt in reading['Voltages']:
if volt['Name'] == sensor['name'] and 'ReadingVolts' in volt:
return SensorReading(None, sensor, value=volt['ReadingVolts'], units='V')
if volt['Name'] == sensor['name']:
val = volt.get('ReadingVolts', None)
unavail = val is None
return SensorReading(
None, sensor, value=val, units='V',
unavailable=unavail)
def list_media(self):
bmcinfo = self._do_web_request(self._bmcurl)