From 2a44ee68c7933fb46eb8e9034a45ece725f189f6 Mon Sep 17 00:00:00 2001 From: Jarrod Johnon Date: Tue, 23 Sep 2014 15:51:18 -0400 Subject: [PATCH] Remove overly aggressive packet processing With the socket pooling, we no longer have to be as aggressive about trying to get packets out of the socket buffer. However, in a very busy system of several hundred nodes, this aggressive processing tends to produce larger python stacks and can exceed the default 1,000 limit. We may have to resort to increasing the limit one day, but for now this case can be avoided. Change-Id: I83bdaa2d8ad464727a69e6ece064f51cd4318822 --- pyghmi/ipmi/private/session.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/pyghmi/ipmi/private/session.py b/pyghmi/ipmi/private/session.py index 1db4fdd4..0100bc6e 100644 --- a/pyghmi/ipmi/private/session.py +++ b/pyghmi/ipmi/private/session.py @@ -1403,11 +1403,6 @@ class Session(object): self.nowait = False def _xmit_packet(self, retry=True, delay_xmit=None): - if not self.nowait: # if we are retrying, we really need to get the - # packet out and get our timeout updated - Session.wait_for_rsp(timeout=0, callout=False) # take opportunity - # to drain the socket queue if - # applicable if self.sequencenumber: # seq number of zero will be left alone, it is # special, otherwise increment self.sequencenumber += 1