xCAT/pyghmi
2
0
Fork 0
mirror of https://opendev.org/x/pyghmi synced 2025-01-15 20:27:45 +00:00
Code Issues Projects Releases Wiki Activity

Raise IpmiException on an error setting/getting the boot device

Browse Source 
Currently if an error happens when setting/getting the boot device pyghmi
is returning a dictorary with the error, instead I think it should raise
an exception just like other methods (e.g set_power, get_power) does.

Change-Id: Ifaebd5ff578ff670950e2ebe584c235d20fce145
This commit is contained in:
Lucas Alvares Gomes 2014-07-23 10:28:20 +01:00
parent 8740687e0f
commit 14573871eb
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pyghmi/ipmi/command.py
View File

@ -128,12 +128,13 @@ class Command(object):
BIOS or UEFI fail to honor it. This is usually only applicable to the
next reboot.
:raises: IpmiException on an error.
:returns: dict --The response will be provided in the return as a dict
"""
response = self.raw_command(netfn=0, command=9, data=(5, 0, 0))
# interpret response per 'get system boot options'
if 'error' in response:
return response
raise exc.IpmiException(response['error'])
# this should only be invoked for get system boot option complying to
# ipmi spec and targeting the 'boot flags' parameter
assert (response['command'] == 9 and
@ -231,6 +232,7 @@ class Command(object):
should BIOS boot and offers no "don't care" option.
In practice, this flag not being set does not preclude
UEFI boot on any system I've encountered.
:raises: IpmiException on an error.
:returns: dict or True -- If callback is not provided, the response
"""
if bootdev not in boot_devices:
@ -241,7 +243,7 @@ class Command(object):
# Set System Boot Options is netfn=0, command=8, data
response = self.raw_command(netfn=0, command=8, data=(3, 8))
if 'error' in response:
return response
raise exc.IpmiException(response['error'])
bootflags = 0x80
if uefiboot:
bootflags |= 1 << 5
@ -252,7 +254,7 @@ class Command(object):
data = (5, bootflags, bootdevnum, 0, 0, 0)
response = self.raw_command(netfn=0, command=8, data=data)
if 'error' in response:
return response
raise exc.IpmiException(response['error'])
return {'bootdev': bootdev}
def raw_command(self, netfn, command, bridge_request=(), data=(),