2
0
mirror of https://github.com/xcat2/confluent.git synced 2024-11-26 03:19:48 +00:00
Commit Graph

104 Commits

Author SHA1 Message Date
Jarrod Johnson
763ccf823f Improve error reporting by server
General errors were uncaught.  Provide a way
to relate unexpected situations more gracefully
to a client.
2015-03-19 14:55:40 -04:00
Jarrod Johnson
8d09fb4064 Rework ipmi plugin
IPMI plugin is simplified and able to do multi-node requests.
2015-03-17 17:04:32 -04:00
Jarrod Johnson
6a3025837b Batch nodes to plugin calls
Every node was serialized in being passed to plugins.  Fix this
by grouping the nodes by the handler function, and then calling
them by batch.  This still serializes each plugin, but for now this should
suffice.
2015-03-17 11:05:28 -04:00
Jarrod Johnson
a4f3366a57 Fix numerous issues with noderange calls
get_node_attributes would make a fatal mistake when more
than one node queried due to loop side effect.  Also address
numerous issue with html-ification in the messaging module.
2015-03-16 09:46:03 -04:00
Jarrod Johnson
41cccb01f6 Bring noderange somewhat to life
Noderange based operations are now online.  Investigation required
to understand underwhelming performance (e.g. health/hardware)
and trace error when trying to show things on console-only nodes
 (like power state).  The html api browser handling of power/state and
 similar needs a look (though json through http is fine) and confetty
 client display of the data needs work still.
2015-03-13 17:12:31 -04:00
Jarrod Johnson
1be6486df0 Refactor core
With the branches for node versus nodegroup and noderange a function was unwieldy.
Break it up to be more manageable.  Also address a defect where client omission of traling '/'
would break nodegroup elements.
2015-03-13 14:13:11 -04:00
Jarrod Johnson
50274f745e Fix range operator not validating nodes
When a node that doesn't exist is implied by a noderange, correctly indicate failure when
config verification is engaged.
2015-03-13 14:11:54 -04:00
Jarrod Johnson
9f16375b14 Make noderange attribute pass through API better
On the plugin front, add a one-off description for the 'noderange' attribute.
For the other pieces, make noderange more like any 'extensible' string value
rather than making it special.
2015-03-12 15:59:25 -04:00
Jarrod Johnson
0515acd054 First part of hooking noderange into configuration
Make expansion of groups and rejection of unrecognized elements work.
Additionally, implement dynamic groups.  A group may have a 'noderange'
attribute.  In this case it is considered to have 'dynamic' members.  This
only has meaning in noderange expansion, not in deriving configuration data.
This does not yet add the search by attribute value capabilities and still
doesn't do the pagination or + operators.
2015-03-12 15:38:50 -04:00
Jarrod Johnson
7a346ed0d3 Bring noderange up to mostly working order
Implement [] and - and :.  Actually do better than xCAT NodeRange.pm about
multiple numbers in the non-[] sequential range case.  Still need to do the things
that requiring wiring up to a config manager (the atom verification as well as
=, =~, and [0] being ~ or / for regex names).
2015-03-11 17:02:26 -04:00
Jarrod Johnson
6dc2ec20a0 Address shellmodule management issues
shellmodule plugins could fall over in unfortunate
ways inducing confusing.  Mitigate that risk to
some degree.
2015-03-05 14:06:35 -05:00
Jarrod Johnson
22c1e73599 Fix whitespace in sockapi.py
A hardtab was in sockapi.py, making it unable to build on my system.
Make the indentation match the rest of the project.
2015-02-27 16:26:27 -05:00
Jarrod Johnson
48b73f6857 Better handle random exceptions in console plugins
If a console plugin raises some unrecognized exception,
handle it more gracefully with trace log capture and moving
on.
2015-02-27 12:17:28 -05:00
Jarrod Johnson
5137f1881a Try to avoid going into negative client count
The root cause for negative has not been determined,
however reduce the hypothetical exposure to the issue
in the hopes of filtering out extraneous problems.
2015-02-27 12:10:24 -05:00
Jarrod Johnson
57e39a31c5 Merge branch 'master' of ssh://git.code.sf.net/p/xcat/confluent 2015-02-27 11:55:47 -05:00
Jarrod Johnson
9530f76af3 Avoid attempting to log negative client count
If another bug causes client count to go negative,
at least avoid sending that mistake to log, except
as part of a trace log.
2015-02-27 11:54:43 -05:00
Victor Hu
3756ee129a Checking for ppc64 and setting the SO_PEERCRED to 21.
The socket.SO_PEERCRED seemed to work fine for my
ppc64 RHEL system, but testing today on little-
endian SLES 12 system threw that exception. So
checking if the arch is "ppc64" on the exception
case.
2015-02-10 17:16:10 -05:00
Jarrod Johnson
a009f4c6d1 Change PAM behavior for authorization
Previously, any PAM result was treated as good.  This isn't
actually of practical value, since we need a user object to
really do authorization.  Change strategy to give pam a chance
to deny anyone, but require the user to exist in confluent
even if pam says the user is a valid one.
2015-02-03 11:04:32 -05:00
Jarrod Johnson
0cd4ffcd3b Implement client reconnect on server restart
When the server restarts, clients should try to reconnect seamlessly.
Doing so allows maintenance without being overly disruptive to users.
2015-02-03 10:15:08 -05:00
Victor Hu
54491e3832 On successful builds, clean up the generated directories and files
created during the build so generated files are not accidently
commited to git.  Print a error message when rpmbuild fails
2015-02-02 16:41:37 -05:00
Jarrod Johnon
98a3f6fcdc Relay target unreachable condition to client
If connectivity is lost in the midst of an interrogation,
relay the unreachable status to the client rather than
'Internal Error' that was occuring before.
2015-01-22 13:56:16 -05:00
Victor Hu
98302088bd Merge branch 'master' of ssh://git.code.sf.net/p/xcat/confluent 2015-01-21 16:43:17 -05:00
Jarrod Johnon
cb32c18507 Correct 'selfself' mistake in last commit
Previous commit had a typo that required correction.
2015-01-21 16:39:00 -05:00
Victor Hu
78b5cb15ce Make ..confluent/plugins/console directory owned by confluent
xcathmc.sh is a xCAT console wrapper needed to be placed in the
confluent consoles plugin directory.  Talking with Jarrod, it was
decided that confluent should stay stand-alone and xCAT should ship
this and related "glue" items in a separate RPM.  The empty 'console'
directory should be owned by the confluent RPM
2015-01-21 16:35:22 -05:00
Victor Hu
09acf04111 Add RPM dependency for PyPAM package 2015-01-21 16:31:08 -05:00
Jarrod Johnon
a9eab61567 Handle broken cookies from other sites in domain
If a web application in a wider domain sets a cookie that python
doesn't like, a CookieError would be raised to ruin the whole request.
Address by subclassing SimpleCookie to catch the cookie error and
set an empty Morsel rather than fail out.  This allows the errant
cookie to be ignored while still being able to check for the cookie
that we actually care about.
2015-01-21 16:20:55 -05:00
Jarrod Johnon
a366520670 Fix circular import problem
The change to allow configmanager to log traces
erroneously broke due to use of 'import .. as' in
circular imports.  Skip 'as' and the problem does not occur.
2015-01-21 14:22:53 -05:00
Jarrod Johnon
de383630cf Gracefully trap config change callback errors
When a change callback handler raises an exception,
log it and move on to next handler.  This prevents
the handler from screwing up the caller or fellow
callback handlers.  Unfortunately this means that
no one notices the issue until checking the trace
log file, but it produces more peculiar behavior
as it stands without this change.
2015-01-19 17:05:29 -05:00
Jarrod Johnon
cfb9575a5e Fix configuration auto-fixup in ipmi
If a session was attempted but failed before creation, a trace was thrown.
Fix this by catching the scenario and passing, since the desired effect is
already there.
2015-01-19 16:32:30 -05:00
Jarrod Johnon
5ddc97603a Fix trace on unresolvable manager in ipmi
If hardwaremanagement.manager did not resolve, a trace
was generated.  Fix by properly indicating the endpoint
was unreachable.
2015-01-19 16:22:22 -05:00
Jarrod Johnon
dc28f962dc Add sensor support to the ipmi plugin
Manage collections of sensor resources as presented by ipmi devices
2015-01-19 14:49:23 -05:00
Jarrod Johnon
384baea038 Handle non-ascii unicode better
Clarify that the data is in UTF-8 where applicable.  It is expected
that clients are capable of handling UTF-8 for now.  Additionally,
the HTML api explorer handling of numeric data is fixed.
2015-01-19 14:45:24 -05:00
Jarrod Johnon
6acaac8644 Add one-call tracing to log-as-a-file
When a log object is used as a 'dumb' file target, show the origin of the
output.  The motivation here is that 'print' statements are intended to
be an unusual event that should be easily tracked down and eliminated
once their specific use has concluded.
In xcatd, running '-f' means a lot of mysterious output that is hard
to manage as they frequently print out variable contents without
searchable context.  For example, if in xcatd someone randomply prints out
a varibale with a nodename, we might see a stray:
n1
With this change (together with previous changes), the same statement
results in stdout log appearing like:
Jan 19 14:20:54   File "/opt/confluent/lib/python/confluent/plugins/hardwaremanagement/ipmi.py", line 364, in _dict_sensor
    print nodename: n1
2015-01-19 14:35:22 -05:00
Jarrod Johnon
8bc6477700 Implement plugin curated collections
A plugin is now allowed to define a collection.  The sensors
hierarchy is added as the first path to allow plugin curated
collections.  ipmi plugin updated to list items in those
collections
2015-01-15 11:28:22 -05:00
Jarrod Johnon
c86e1af750 Try to use socket to get SO_PEERCRED
Newer socket includes SO_PEERCRED.  Try to use that before resorting
to the 17 assumption.
2015-01-13 15:01:55 -05:00
Jarrod Johnon
fa2b845b55 Fix sign of SO_PEERCRED
SO_PEERCRED uses ucred, where pid is signed and the other two are not.
Accurately handle large uid/gid
2015-01-13 11:55:33 -05:00
Jarrod Johnon
09c5b90c57 Fix internal error on boot device mistake
Boot device not being str resulted in internal error rather than the
intended message.  Correct by forcing it to string representation.
2015-01-13 08:59:48 -05:00
Jarrod Johnon
10369decf8 Fix ipmi get boot device when uefimode is possible 2015-01-12 10:37:05 -05:00
jjohnson2
4dbb2ee395 Bump version number of server
Changes have occurred since 1.0, disambiguate from last release.
2014-11-25 14:16:50 -05:00
Jarrod Johnon
cbcfc9a0a4 Merge branch 'master' of ssh://git.code.sf.net/p/xcat/confluent 2014-11-25 14:04:08 -05:00
Jarrod Johnon
f9b27eb426 Return '' for identify state on read ipmi
For exploring the api, a write-only attribute presents difficulty.  Address this by allowing
plugins to return a '' value and have ipmi plugin return that value to enable things
like the web api explorer.
2014-11-25 14:03:41 -05:00
Jarrod Johnon
a645e256eb Add identify support
In the course of adding identify support, also took the opportunity to address
a few mistakes and refactor some code for future ease of development.
2014-11-25 13:57:31 -05:00
jjohnson2
8a92450abc Bump version to 1.0
Release candidate.  If no further issues reported in test, this will be 1.0
2014-11-21 15:35:53 -05:00
Jarrod Johnon
059b448932 Cleanly handle stop/restart when not running
Previously some rather uncomfortable looking output would be emitted at someone trying to restart
confluent if not running.  Be nicer and recognize when service is not running and a stop attempt is made.
2014-11-18 17:02:54 -05:00
Jarrod Johnon
bf15f12a1c Manage the bootmode of nextdevice
Plugins may implement bootmode as appropriate.  Currently, the only
example usage is how IPMI can indicate BIOS style versus UEFI style
boot.

Additionally, limitations of the ChoiceMessage base object around
handling multi-parameter pieces of data are addressed.
2014-11-14 16:41:47 -05:00
Jarrod Johnon
7e2b6b6a85 More easily recognize application/json input in request data for POST
Browsers may include more data.  Tolerate by doing a substring search as is the case for form data.
2014-11-07 11:03:44 -05:00
Jarrod Johnon
6289e3ebfa Correct typo in httpapi
Consoles would not work due to a type of dictionary name, correct the mistake
2014-11-04 13:51:23 -05:00
Jarrod Johnon
af9a5c13c1 Modify to work better in a RHEL6/RHEL7 agnostic way 2014-11-04 13:34:26 -05:00
Jarrod Johnon
74a83a4502 Init script modifications for SLES 2014-11-04 12:49:31 -05:00
Jarrod Johnon
f2c7c8ace3 Increase version numbers for pre-RC testing 2014-11-04 10:13:09 -05:00