xCAT/confluent
2
0
Fork 0
mirror of https://github.com/xcat2/confluent.git synced 2024-11-22 09:32:21 +00:00
Code Issues Projects Releases Wiki Activity

Remove 'null' workaround to UEFI not resetting appmode

Browse Source 
Firmware fixes obsolete the need.  The bad behavior on older firmware
is sufficiently tolerable that code to workaround that could have bad
side effects can reasonably be abolished.
This commit is contained in:
Jarrod Johnson 2014-04-03 15:01:51 -04:00
parent 8fa8951896
commit e2e2d884b7
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
confluent/consoleserver.py
View File

@ -136,15 +136,9 @@ class _ConsoleHandler(object):
if data == conapi.ConsoleEvent.Disconnect:
self._got_disconnected()
return
prefix = ''
if '\0' in data: # there is a null in the output
# the proper response is to do nothing, but here using it as a cue
# that perhaps firmware has reset since that's the only place
# observed so far. Lose the shiftin and app mode when detected
prefix = '\x1b[?1l'
self.shiftin = None
if '\x1b[?1l' in data: # request for ansi mode cursor keys
self.appmodedetected = False
if '\x1b[?1h' in data: # remember the session wants the client to be in
if '\x1b[?1h' in data: # remember the session wants the client to use
# 'application mode' Thus far only observed on esxi
self.appmodedetected = True
if '\x1b)0' in data:
@ -162,7 +156,7 @@ class _ConsoleHandler(object):
# certificate signing request
if len(self.buffer) > 16384:
self.flushbuffer()
self._send_rcpts(prefix + data)
self._send_rcpts(data)
def _send_rcpts(self, data):
for rcpt in self.rcpts.itervalues():