From dbcc33629afad9e551daa00e16288c981eaa719b Mon Sep 17 00:00:00 2001 From: Jarrod Johnson <jjohnson2@lenovo.com> Date: Thu, 3 Aug 2017 08:33:29 -0400 Subject: [PATCH] Fix nodeshell overeager parsing In the case of execing to ssh, preserve literal argumants since ssh is going to parse them. Pre-parsing will cause ssh to strip out spaces, for example. --- confluent_client/bin/nodeshell | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/confluent_client/bin/nodeshell b/confluent_client/bin/nodeshell index 30f84242..b418eb73 100755 --- a/confluent_client/bin/nodeshell +++ b/confluent_client/bin/nodeshell @@ -19,7 +19,6 @@ from collections import deque import optparse import os import select -import shlex import signal import subprocess import sys @@ -62,7 +61,7 @@ def run(): ex = exp['databynode'] for node in ex: cmd = ex[node]['value'].encode('utf-8') - cmdv = ['ssh', node] + shlex.split(cmd) + cmdv = ['ssh', node, cmd] if currprocs < concurrentprocs: currprocs += 1 run_cmdv(node, cmdv, all, pipedesc)