From b0c384c9ca1436334bf23d8f6fd2b6fb6b61b1b3 Mon Sep 17 00:00:00 2001 From: Jarrod Johnson Date: Thu, 12 Jul 2018 16:05:04 -0400 Subject: [PATCH] Check quorum on attribute read It's too bizarre for attribute read from api to work without quorum, could be misleading. --- confluent_server/confluent/config/configmanager.py | 4 ++++ .../confluent/plugins/configuration/attributes.py | 1 + 2 files changed, 5 insertions(+) diff --git a/confluent_server/confluent/config/configmanager.py b/confluent_server/confluent/config/configmanager.py index 900958ca..1e7eb4ff 100644 --- a/confluent_server/confluent/config/configmanager.py +++ b/confluent_server/confluent/config/configmanager.py @@ -828,6 +828,10 @@ class ConfigManager(object): def get_collective_member(self, name): return get_collective_member(name) + @classmethod + def check_quorum(cls): + return check_quorum() + def filter_node_attributes(self, expression, nodes=None): """Filtered nodelist according to expression diff --git a/confluent_server/confluent/plugins/configuration/attributes.py b/confluent_server/confluent/plugins/configuration/attributes.py index 36baf330..2b135790 100644 --- a/confluent_server/confluent/plugins/configuration/attributes.py +++ b/confluent_server/confluent/plugins/configuration/attributes.py @@ -20,6 +20,7 @@ import confluent.util as util def retrieve(nodes, element, configmanager, inputdata): + configmanager.check_quorum() if nodes is not None: return retrieve_nodes(nodes, element, configmanager, inputdata) elif element[0] == 'nodegroups':