From 75484db014d171fc2f15daa32048da08e55add37 Mon Sep 17 00:00:00 2001 From: Jarrod Johnson Date: Mon, 3 Oct 2022 10:33:21 -0400 Subject: [PATCH] Fix macok incorrect value on finding the mac --- confluent_server/bin/confluent_selfcheck | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/confluent_server/bin/confluent_selfcheck b/confluent_server/bin/confluent_selfcheck index 74c58f51..72a1857b 100755 --- a/confluent_server/bin/confluent_selfcheck +++ b/confluent_server/bin/confluent_selfcheck @@ -253,7 +253,7 @@ if __name__ == '__main__': if key.endswith('.hwaddr'): mac = rsp[key].get('value', None) if mac: - macok = trusted + macok = True if not uuidok and not macok: allok = False emprint(f'{args.node} does not have a uuid or mac address defined in id.uuid or net.*hwaddr, deployment will not work') @@ -278,3 +278,6 @@ if __name__ == '__main__': print("OK") else: print("Skipping node checks, no node specified (Example: confluent_selfcheck -n n1)") +# possible checks: +# arping on the node, check for dupes/against nodeinventory? +# arping -D for mgt own ip addresses? check for dupes, also check for bleed through from one nic to another